Skip to content

chore: prepare for 0.16.0-alpha.1 release#2290

Merged
igamigo merged 24 commits into
nextfrom
jmunoz-update-miden-deps
Jul 17, 2026
Merged

chore: prepare for 0.16.0-alpha.1 release#2290
igamigo merged 24 commits into
nextfrom
jmunoz-update-miden-deps

Conversation

@juan518munoz

Copy link
Copy Markdown
Collaborator

Closes #2171

@juan518munoz

Copy link
Copy Markdown
Collaborator Author

Head's up

Switched the build-wasm job from default github runner to warp in an attempt to prevent running out of memory.
https://github.com/0xMiden/rust-sdk/actions/runs/28537644563/job/84603019305?pr=2290

@juan518munoz
juan518munoz marked this pull request as ready for review July 7, 2026 22:03
@igamigo
igamigo self-requested a review July 8, 2026 00:36

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some comments, mostly minor. The biggest one is related to replacing our own patch structures with the new protocol ones. Let me know if you have any questions!

Comment thread crates/rust-client/src/grpc_support/mod.rs Outdated
Comment thread crates/rust-client/src/store/smt_forest.rs Outdated
Comment thread crates/rust-client/src/store/smt_forest.rs Outdated
Comment thread CHANGELOG.md Outdated
Comment thread scripts/start-test-node.sh Outdated
Comment thread crates/sqlite-store/src/sync.rs Outdated
Comment thread crates/rust-client/src/sync/state_sync_update.rs Outdated
@juan518munoz

Copy link
Copy Markdown
Collaborator Author

761cccb is meant to address client side store error detailed on 0xMiden/node#2328

@juan518munoz juan518munoz changed the title chore: switch back miden deps to git next chore: prepare for 0.16.0-alpha.1 release Jul 13, 2026
@juan518munoz

Copy link
Copy Markdown
Collaborator Author

8df24f5 changed scope of this PR, we are now targetting an alpha for 0.16.0

Comment thread scripts/start-test-node.sh Outdated
Comment thread CHANGELOG.md Outdated
### Breaking Changes

* [BREAKING][rust][cli] Removed the client debug-mode toggle: `DebugMode`, `ClientBuilder::in_debug_mode`, `Client::in_debug_mode`, the CLI `--debug` flag, and the `MIDEN_DEBUG` environment variable are gone, along with the `debug_mode` parameter of `CliClient::new`/`CliClient::from_config`. Miden VM 0.24 replaced the flag-gated `debug.*` MASM decorators with `miden::core::debug` procedures whose output the transaction executor prints by default, so the toggle no longer had anything to gate. ([#2290](https://github.com/0xMiden/rust-sdk/pull/2290)).
* [BREAKING][rust] Migrated to `miden-protocol` 0.16. Transaction-level fees were removed, block-level `FeeParameters` are unchanged. The relative `AccountDelta` model was replaced by the absolute `AccountPatch` model for account updates: `TransactionResult::account_delta` is now `account_patch`, `AccountUpdateDetails::Public` now carries an `AccountPatch`, account reconstruction is done via `Account::try_from(&AccountPatch)` or `Account::apply_patch` instead of previous `apply_delta`. Re-exports changed accordingly: `AccountStorageDelta` for `AccountStoragePatch`, `StorageMapDelta` for `StorageMapPatch`, and so on. Standards APIs were updated: `AuthMethod` was removed (use the concrete auth components), `create_fungible_faucet` became `create_user_fungible_faucet`. ([#2290](https://github.com/0xMiden/rust-sdk/pull/2290)).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this is a bit outdated because I haven't seen any create_user_fungible_faucet

Comment on lines 35 to 40
#[cfg(test)]
use miden_client::assembly::CodeBuilder;
#[cfg(test)]
use miden_client::auth::Approver;
#[cfg(test)]
use miden_client::auth::{AuthSchemeId, AuthSecretKey, AuthSingleSig};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these #[cfg(test)]?

Comment thread bin/miden-cli/build.rs
Comment thread bin/miden-cli/Cargo.toml Outdated
assert_cmd = { workspace = true }
miden-client = { features = ["testing"], workspace = true }
midenc-hir-type = "0.6"
midenc-hir-type = "0.9"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why do we currently need this? In any case, would be nice to do { version = "0.9" } for consistency

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK there shouldn't be any need to depend on this directly outside the assembler/compiler, but since it's just a dev dependency, I'm guessing it is something testing related?

Comment thread crates/rust-client/src/account/account_reader.rs Outdated
Comment thread crates/rust-client/src/remote_prover/generated.rs
Comment thread crates/sqlite-store/src/sync.rs Outdated
Comment thread crates/rust-client/src/rpc/domain/account_vault.rs Outdated
Comment thread crates/rust-client/src/rpc/domain/storage_map.rs Outdated
Comment thread crates/rust-client/src/rpc/mod.rs
.map(|(slot_name, value_patch)| {
(
slot_name.clone(),
(value_patch.value().unwrap_or_default(), StorageSlotType::Value),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think unwrap_or_default() turns a remove into a zero word. I don't think we eventually want this, even if for now it will work correctly because the protocol does not generate Remove. Let's make it an expect() for now and add an issue to address this later

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not leaving the approve just yet because we need to make sure we use the crates.io versions of the crates, and also solve conflicts and review failing tests, but overall looks good

Comment thread Cargo.toml Outdated
@juan518munoz

Copy link
Copy Markdown
Collaborator Author

The remaining integration test failures are all from agglayer. It's accounts are built by miden-agglayer, which gives no way to add the node's expiration tx script to their allowlist and neither sets it up by defailt.

This is the same root cause as the ntx tests fixed in b813d10.

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we can merge this once the new alpha crates get released

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think there might be some ways to simplify this script, but let's not worry about this too much for now

Comment thread Cargo.toml
miden-agglayer = { default-features = false, version = "0.16.0-alpha.3" }
miden-protocol = { default-features = false, version = "0.16.0-alpha.3" }
miden-standards = { default-features = false, version = "0.16.0-alpha.3" }
miden-testing = { default-features = false, version = "0.16.0-alpha.2" }

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that miden-testing doesn't have a .4 release like other protocol deps

https://crates.io/crates/miden-testing/versions

Comment thread bin/miden-cli/tests/cli.rs
@igamigo
igamigo merged commit 0f89705 into next Jul 17, 2026
23 checks passed
@igamigo
igamigo deleted the jmunoz-update-miden-deps branch July 17, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply public account updates directly from RPC payloads (skip AccountDelta reconstruction)

5 participants