chore: prepare for 0.16.0-alpha.1 release#2290
Conversation
|
Head's up Switched the |
igamigo
left a comment
There was a problem hiding this comment.
Leaving some comments, mostly minor. The biggest one is related to replacing our own patch structures with the new protocol ones. Let me know if you have any questions!
|
761cccb is meant to address client side store error detailed on 0xMiden/node#2328 |
0.16.0-alpha.1 release
|
8df24f5 changed scope of this PR, we are now targetting an alpha for |
| ### Breaking Changes | ||
|
|
||
| * [BREAKING][rust][cli] Removed the client debug-mode toggle: `DebugMode`, `ClientBuilder::in_debug_mode`, `Client::in_debug_mode`, the CLI `--debug` flag, and the `MIDEN_DEBUG` environment variable are gone, along with the `debug_mode` parameter of `CliClient::new`/`CliClient::from_config`. Miden VM 0.24 replaced the flag-gated `debug.*` MASM decorators with `miden::core::debug` procedures whose output the transaction executor prints by default, so the toggle no longer had anything to gate. ([#2290](https://github.com/0xMiden/rust-sdk/pull/2290)). | ||
| * [BREAKING][rust] Migrated to `miden-protocol` 0.16. Transaction-level fees were removed, block-level `FeeParameters` are unchanged. The relative `AccountDelta` model was replaced by the absolute `AccountPatch` model for account updates: `TransactionResult::account_delta` is now `account_patch`, `AccountUpdateDetails::Public` now carries an `AccountPatch`, account reconstruction is done via `Account::try_from(&AccountPatch)` or `Account::apply_patch` instead of previous `apply_delta`. Re-exports changed accordingly: `AccountStorageDelta` for `AccountStoragePatch`, `StorageMapDelta` for `StorageMapPatch`, and so on. Standards APIs were updated: `AuthMethod` was removed (use the concrete auth components), `create_fungible_faucet` became `create_user_fungible_faucet`. ([#2290](https://github.com/0xMiden/rust-sdk/pull/2290)). |
There was a problem hiding this comment.
Perhaps this is a bit outdated because I haven't seen any create_user_fungible_faucet
| #[cfg(test)] | ||
| use miden_client::assembly::CodeBuilder; | ||
| #[cfg(test)] | ||
| use miden_client::auth::Approver; | ||
| #[cfg(test)] | ||
| use miden_client::auth::{AuthSchemeId, AuthSecretKey, AuthSingleSig}; |
There was a problem hiding this comment.
Why do we need these #[cfg(test)]?
| assert_cmd = { workspace = true } | ||
| miden-client = { features = ["testing"], workspace = true } | ||
| midenc-hir-type = "0.6" | ||
| midenc-hir-type = "0.9" |
There was a problem hiding this comment.
nit: Why do we currently need this? In any case, would be nice to do { version = "0.9" } for consistency
There was a problem hiding this comment.
AFAIK there shouldn't be any need to depend on this directly outside the assembler/compiler, but since it's just a dev dependency, I'm guessing it is something testing related?
| .map(|(slot_name, value_patch)| { | ||
| ( | ||
| slot_name.clone(), | ||
| (value_patch.value().unwrap_or_default(), StorageSlotType::Value), |
There was a problem hiding this comment.
I think unwrap_or_default() turns a remove into a zero word. I don't think we eventually want this, even if for now it will work correctly because the protocol does not generate Remove. Let's make it an expect() for now and add an issue to address this later
igamigo
left a comment
There was a problem hiding this comment.
LGTM! Not leaving the approve just yet because we need to make sure we use the crates.io versions of the crates, and also solve conflicts and review failing tests, but overall looks good
# Conflicts: # CHANGELOG.md # docs/external/src/rust-client/cli/cli-troubleshooting.md
|
The remaining integration test failures are all from agglayer. It's accounts are built by This is the same root cause as the ntx tests fixed in b813d10. |
igamigo
left a comment
There was a problem hiding this comment.
LGTM! I think we can merge this once the new alpha crates get released
There was a problem hiding this comment.
nit: I think there might be some ways to simplify this script, but let's not worry about this too much for now
| miden-agglayer = { default-features = false, version = "0.16.0-alpha.3" } | ||
| miden-protocol = { default-features = false, version = "0.16.0-alpha.3" } | ||
| miden-standards = { default-features = false, version = "0.16.0-alpha.3" } | ||
| miden-testing = { default-features = false, version = "0.16.0-alpha.2" } |
There was a problem hiding this comment.
note that miden-testing doesn't have a .4 release like other protocol deps
Closes #2171