refactor: optimize historical note retrieval#2285
Open
juan518munoz wants to merge 11 commits into
Open
Conversation
JereSalo
reviewed
Jul 3, 2026
Collaborator
There was a problem hiding this comment.
Some of the entries here seem to be duplicated, like the one of send_private_note_with_block_hint and also the bump of miden-note-transport-proto-build to 0.4.1.
Collaborator
Author
There was a problem hiding this comment.
Fixed in the latest merge to next.
JereSalo
approved these changes
Jul 6, 2026
| Ok(ids) | ||
| imported_ids.extend(ids); | ||
|
|
||
| Ok(imported_ids) |
Collaborator
There was a problem hiding this comment.
Thinking out loud: should we dedup this before returning it? As there might be overlap between imported_ids of the backfill and the fetched ones in ids? Probably harmless to keep it as-is though.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion, applied in cea92e0
SantiagoPittella
approved these changes
Jul 8, 2026
SantiagoPittella
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, would be nice a test with exceeding MAX_BACKFILL_TAGS_PER_SYNC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
Client::fetch_all_private_notesand replaces it with an automatic per tag backfill, so consumers no longer have to fetch history themselves after they start tracking a new tag.add_note_tag, an account import, or an address creation).settingstable undernote_transport_covered_tags.Note:
This branch cherry-picks the NTL
0.4.1upgrade from #2264, as PR landed onmainandnextdoes not have it yet, so its three commits are replayed here because the backfill depends on0.4.1(theblock_hintdelivery path).Closes #2258