-
Notifications
You must be signed in to change notification settings - Fork 100
feat: gate input-note script execution behind a trust policy #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JereSalo
wants to merge
25
commits into
next
Choose a base branch
from
note-script-trust-policy
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
29e6a0a
verify root of RPC-fetched note scripts
JereSalo d7ac558
move note-script root verification down to the RPC client
JereSalo f62aaa8
format
JereSalo 07d1703
add per-request note-script trust policy
JereSalo 584adb3
trust custom note scripts where intentionally consumed
JereSalo 9fa3b39
rename builder method to allow_unlisted_note_scripts and simplify CLI…
JereSalo 5ee11ca
Merge remote-tracking branch 'origin/next' into jere/verify-fetched-n…
JereSalo f6d8030
Merge branch 'jere/verify-fetched-note-script-root' into note-script-…
JereSalo 94254bb
clarify NoteScriptTrustPolicy doc-comment scope
JereSalo 2853955
Merge remote-tracking branch 'origin/next' into note-script-trust-policy
JereSalo 12eb7f8
adapt note script trust policy code to NoteScriptRoot type
JereSalo 6944da5
use new note script header in trust policy test
JereSalo 839d45e
document input note script trust policy
JereSalo 3eff659
Merge remote-tracking branch 'origin/next' into note-script-trust-policy
JereSalo 4fe86f1
address review feedback on note script trust policy
JereSalo 6263c59
Merge remote-tracking branch 'origin/next' into note-script-trust-policy
JereSalo 078e3fb
Merge branch 'next' into note-script-trust-policy
TomasArrachea ba60152
fix: merge
TomasArrachea 1e1fda5
Merge remote-tracking branch 'origin/next' into note-script-trust-policy
JereSalo fe2bdb5
fix: adapt note-script trust policy tests to protocol 0.15 API
JereSalo 8c5aeef
fix: trust non-standard note script in ntx public-note integration test
JereSalo 566d974
Merge remote-tracking branch 'origin/next' into note-script-trust-policy
JereSalo cf149f1
Merge remote-tracking branch 'origin/next' into note-script-trust-policy
JereSalo 7c96a7b
Merge remote-tracking branch 'origin/next' into note-script-trust-policy
JereSalo ec50dc8
docs: add changelog entries for the note-script trust policy
JereSalo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is the right entry to put. I just saw the last one was
## 0.16.0-alpha.1 (2026-07-17)and went for this one. We can change it if necessary.