Skip to content

fix/ci: avoid race for port#1727

Merged
Mirko-von-Leipzig merged 2 commits intonextfrom
bernhard-bind-rand-port-exactly-once
Mar 2, 2026
Merged

fix/ci: avoid race for port#1727
Mirko-von-Leipzig merged 2 commits intonextfrom
bernhard-bind-rand-port-exactly-once

Conversation

@drahnr
Copy link
Contributor

@drahnr drahnr commented Mar 2, 2026

We currently re-bind a port, but with our expanding test suite it becomes a race for free ports.

The change passes the listener instead of an address to bind the limited resource once.

@drahnr drahnr added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Mar 2, 2026
@drahnr drahnr force-pushed the bernhard-bind-rand-port-exactly-once branch from bde854d to 728c667 Compare March 2, 2026 12:43
@drahnr drahnr force-pushed the bernhard-bind-rand-port-exactly-once branch from 728c667 to 90b6566 Compare March 2, 2026 13:27
Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; I had previously toyed with making our service startup's.. better but this is a good bandaid until we revisit endpoints/ports etc.

@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 69c3ac9 into next Mar 2, 2026
18 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the bernhard-bind-rand-port-exactly-once branch March 2, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants