Skip to content

perf/store: optimize updating existing accounts #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mirko-von-Leipzig merged 28 commits into from
Mar 4, 2026
Merged

perf/store: optimize updating existing accounts #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2c632b5
feat: do not load the full account from DB
drahnr Feb 16, 2026
a324664
fixup
drahnr Feb 16, 2026
544a668
maybe
drahnr Feb 17, 2026
e44b446
Update CHANGELOG.md
drahnr Feb 18, 2026
c755ff3
error handling
drahnr Feb 18, 2026
230654a
safe
drahnr Feb 23, 2026
3c28426
review comments
drahnr Feb 23, 2026
38cb1fa
remvoe dead code
drahnr Feb 23, 2026
c56ba85
clippy
drahnr Feb 23, 2026
faaad63
better
drahnr Feb 23, 2026
1c8ccd7
undo inlining
drahnr Feb 23, 2026
512d5ca
Merge remote-tracking branch 'origin/next' into bernhard-do-not-load-…
drahnr Feb 25, 2026
689fa87
encode invariant explicitly as debug assertion
drahnr Feb 25, 2026
2480d2d
inner forest changes
drahnr Feb 25, 2026
349d8cb
retain split of insert and update
drahnr Feb 25, 2026
a8e8899
clarity
drahnr Feb 25, 2026
9b90313
review refactor
drahnr Feb 25, 2026
0b72a94
extract two fns
drahnr Feb 25, 2026
b252b64
Merge remote-tracking branch 'origin/next' into bernhard-do-not-load-…
drahnr Feb 26, 2026
30edfe1
remove clippy
drahnr Feb 27, 2026
f396daf
Merge remote-tracking branch 'origin/next' into bernhard-do-not-load-…
drahnr Feb 27, 2026
2e64e58
Merge branch 'next' into bernhard-do-not-load-full-account
drahnr Feb 27, 2026
ccf35d9
Merge remote-tracking branch 'origin/next' into bernhard-do-not-load-…
drahnr Mar 2, 2026
aec2a6d
Merge remote-tracking branch 'origin/next' into bernhard-do-not-load-…
drahnr Mar 2, 2026
d95dbb3
Merge branch 'next' into bernhard-do-not-load-full-account
drahnr Mar 2, 2026
e7174a8
comment
drahnr Mar 3, 2026
b52b404
comment
drahnr Mar 3, 2026
c06feec
Merge remote-tracking branch 'origin/next' into bernhard-do-not-load-…
drahnr Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,34 +79,35 @@

### Enhancements

- Cleanup old account data from the database on apply block ([#1304](https://github.com/0xMiden/node/issues/1304)).
- Added block validation endpoint to validator and integrated with block producer ([#1382](https://github.com/0xMiden/node/pull/1381)).
- Added support for timeouts in the WASM remote prover clients ([#1383](https://github.com/0xMiden/node/pull/1383)).
- Added mempool statistics to the block producer status in the `miden-network-monitor` binary ([#1392](https://github.com/0xMiden/node/pull/1392)).
- Added `GetLimits` endpoint to the RPC server ([#1410](https://github.com/0xMiden/node/pull/1410)).
- Added chain tip to the block producer status ([#1419](https://github.com/0xMiden/node/pull/1419)).
- Added success rate to the `miden-network-monitor` binary ([#1420](https://github.com/0xMiden/node/pull/1420)).
- The mempool's transaction capacity is now configurable ([#1433](https://github.com/0xMiden/node/pull/1433)).
- Added pagination to `GetNetworkAccountIds` store endpoint ([#1452](https://github.com/0xMiden/node/pull/1452)).
- Integrated NTX Builder with validator via `SubmitProvenTransaction` RPC ([#1453](https://github.com/0xMiden/node/pull/1453)).
- Integrated RPC stack with Validator component for transaction validation ([#1457](https://github.com/0xMiden/node/pull/1457)).
- Added partial storage map queries to RPC ([#1428](https://github.com/0xMiden/node/pull/1428)).
- Added explorer status to the `miden-network-monitor` binary ([#1450](https://github.com/0xMiden/node/pull/1450)).
- Added validated transactions check to block validation logic in Validator ([#1460](https://github.com/0xMiden/node/pull/1460)).
- Added gRPC-Web probe support to the `miden-network-monitor` binary ([#1484](https://github.com/0xMiden/node/pull/1484)).
- Added DB schema change check ([#1268](https://github.com/0xMiden/node/pull/1485)).
- Added foreign account support to validator ([#1493](https://github.com/0xMiden/node/pull/1493)).
- Decoupled ntx-builder from block-producer startup by loading network accounts asynchronously via a background task ([#1495](https://github.com/0xMiden/node/pull/1495)).
- Improved DB query performance for account queries ([#1496](https://github.com/0xMiden/node/pull/1496)).
- The network monitor now marks the chain as unhealthy if it fails to create new blocks ([#1512](https://github.com/0xMiden/node/pull/1512)).
- Limited number of storage map keys in `GetAccount` requests ([#1517](https://github.com/0xMiden/node/pull/1517)).
- Block producer now detects if it is desync'd from the store's chain tip and aborts ([#1520](https://github.com/0xMiden/node/pull/1520)).
- Pin tool versions in CI ([#1523](https://github.com/0xMiden/node/pull/1523)).
- Add `GetVaultAssetWitnesses` and `GetStorageMapWitness` RPC endpoints to store ([#1529](https://github.com/0xMiden/node/pull/1529)).
- Add check to ensure tree store state is in sync with database storage ([#1532](https://github.com/0xMiden/node/issues/1534)).
- Ensure store terminates on nullifier tree or account tree root vs header mismatch (#[#1569](https://github.com/0xMiden/node/pull/1569)).
- Added support for foreign accounts to `NtxDataStore` and add `GetAccount` endpoint to NTX Builder gRPC store client ([#1521](https://github.com/0xMiden/node/pull/1521)).
- Use paged queries for tree rebuilding to reduce memory usage during startup ([#1536](https://github.com/0xMiden/node/pull/1536)).
- Cleanup old account data from the database on apply block ([#1304](https://github.com/0xMiden/miden-node/issues/1304)).
- Added block validation endpoint to validator and integrated with block producer ([#1382](https://github.com/0xMiden/miden-node/pull/1381)).
- Added support for timeouts in the WASM remote prover clients ([#1383](https://github.com/0xMiden/miden-node/pull/1383)).
- Added mempool statistics to the block producer status in the `miden-network-monitor` binary ([#1392](https://github.com/0xMiden/miden-node/pull/1392)).
- Added `GetLimits` endpoint to the RPC server ([#1410](https://github.com/0xMiden/miden-node/pull/1410)).
- Added chain tip to the block producer status ([#1419](https://github.com/0xMiden/miden-node/pull/1419)).
- Added success rate to the `miden-network-monitor` binary ([#1420](https://github.com/0xMiden/miden-node/pull/1420)).
- The mempool's transaction capacity is now configurable ([#1433](https://github.com/0xMiden/miden-node/pull/1433)).
- Added pagination to `GetNetworkAccountIds` store endpoint ([#1452](https://github.com/0xMiden/miden-node/pull/1452)).
- Integrated NTX Builder with validator via `SubmitProvenTransaction` RPC ([#1453](https://github.com/0xMiden/miden-node/pull/1453)).
- Integrated RPC stack with Validator component for transaction validation ([#1457](https://github.com/0xMiden/miden-node/pull/1457)).
- Added partial storage map queries to RPC ([#1428](https://github.com/0xMiden/miden-node/pull/1428)).
- Added explorer status to the `miden-network-monitor` binary ([#1450](https://github.com/0xMiden/miden-node/pull/1450)).
- Added validated transactions check to block validation logic in Validator ([#1460](https://github.com/0xMiden/miden-node/pull/1460)).
- Added gRPC-Web probe support to the `miden-network-monitor` binary ([#1484](https://github.com/0xMiden/miden-node/pull/1484)).
- Added DB schema change check ([#1268](https://github.com/0xMiden/miden-node/pull/1485)).
- Added foreign account support to validator ([#1493](https://github.com/0xMiden/miden-node/pull/1493)).
- Decoupled ntx-builder from block-producer startup by loading network accounts asynchronously via a background task ([#1495](https://github.com/0xMiden/miden-node/pull/1495)).
- Improved DB query performance for account queries ([#1496](https://github.com/0xMiden/miden-node/pull/1496)).
- The network monitor now marks the chain as unhealthy if it fails to create new blocks ([#1512](https://github.com/0xMiden/miden-node/pull/1512)).
- Limited number of storage map keys in `GetAccount` requests ([#1517](https://github.com/0xMiden/miden-node/pull/1517)).
- Block producer now detects if it is desync'd from the store's chain tip and aborts ([#1520](https://github.com/0xMiden/miden-node/pull/1520)).
- Pin tool versions in CI ([#1523](https://github.com/0xMiden/miden-node/pull/1523)).
- Add `GetVaultAssetWitnesses` and `GetStorageMapWitness` RPC endpoints to store ([#1529](https://github.com/0xMiden/miden-node/pull/1529)).
- Add check to ensure tree store state is in sync with database storage ([#1532](https://github.com/0xMiden/miden-node/issues/1534)).
- Improve speed of account updates ([#1567](https://github.com/0xMiden/miden-node/pull/1567)).
- Ensure store terminates on nullifier tree or account tree root vs header mismatch (#[#1569](https://github.com/0xMiden/miden-node/pull/1569)).
- Added support for foreign accounts to `NtxDataStore` and add `GetAccount` endpoint to NTX Builder gRPC store client ([#1521](https://github.com/0xMiden/miden-node/pull/1521)).
- Use paged queries for tree rebuilding to reduce memory usage during startup ([#1536](https://github.com/0xMiden/miden-node/pull/1536)).

### Changes

Expand Down
Loading
Loading