Replace noteCommitmentRoot with historicalNoteRootAccumulatorRoot#1
Open
RogerPodacter wants to merge 1 commit into
Open
Replace noteCommitmentRoot with historicalNoteRootAccumulatorRoot#1RogerPodacter wants to merge 1 commit into
RogerPodacter wants to merge 1 commit into
Conversation
…toricalNoteRootAccumulatorRoot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
High risk because it changes the zk circuit’s public inputs and adds new Merkle membership constraints, requiring a regenerated verifying key and updated on-chain verifier/precompile wiring; any mismatch will break proof verification or acceptance rules.
Overview
Updates the EIP-8182 pool proof interface by replacing
noteCommitmentRootwithhistoricalNoteRootAccumulatorRootas the first public input and adjusting all test vectors accordingly.Extends the pool circuit so each real input proves membership in a private per-input
inNoteRootand separately proves thatinNoteRootis included in a public historical accumulator via a newHistoricalNoteRootLeafPoseidon domain and an additional depth-32 Merkle path.Regenerates and wires the updated proving/verification artifacts: updates
PoolGroth16Verifierconstants,MockPoolPrecompilepublic input layout, installer script initialization for the new accumulator empty root, and refreshes EIP-8182 assets (pool_vk.sha256, precompile JSON fixtures, andshielded-pool-state.jsonbytecode/storage).Reviewed by Cursor Bugbot for commit de4f575. Bugbot is set up for automated code reviews on this repo. Configure here.