Skip to content

Replace noteCommitmentRoot with historicalNoteRootAccumulatorRoot#1

Open
RogerPodacter wants to merge 1 commit into
mainfrom
accum
Open

Replace noteCommitmentRoot with historicalNoteRootAccumulatorRoot#1
RogerPodacter wants to merge 1 commit into
mainfrom
accum

Conversation

@RogerPodacter
Copy link
Copy Markdown
Member

@RogerPodacter RogerPodacter commented May 7, 2026

Note

High Risk
High risk because it changes the zk circuit’s public inputs and adds new Merkle membership constraints, requiring a regenerated verifying key and updated on-chain verifier/precompile wiring; any mismatch will break proof verification or acceptance rules.

Overview
Updates the EIP-8182 pool proof interface by replacing noteCommitmentRoot with historicalNoteRootAccumulatorRoot as the first public input and adjusting all test vectors accordingly.

Extends the pool circuit so each real input proves membership in a private per-input inNoteRoot and separately proves that inNoteRoot is included in a public historical accumulator via a new HistoricalNoteRootLeaf Poseidon domain and an additional depth-32 Merkle path.

Regenerates and wires the updated proving/verification artifacts: updates PoolGroth16Verifier constants, MockPoolPrecompile public input layout, installer script initialization for the new accumulator empty root, and refreshes EIP-8182 assets (pool_vk.sha256, precompile JSON fixtures, and shielded-pool-state.json bytecode/storage).

Reviewed by Cursor Bugbot for commit de4f575. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant