Repository navigation
Add per-channel remove control to merged/overlay docks - #20
Merged
Merged
Conversation
added 2 commits
September 15, 2026 21:03
An overlay group could be built by Ctrl-dragging one dock onto another, but had no way to take a single channel back out short of deleting the whole dock and re-adding what should have stayed. Each entry in a merged dock's per-channel legend now gets a small "x": graph::remove_channel_from_dock drops just that channel from dock_channels[i], and the dock collapses back to a plain single-channel one automatically once one remains, since rendering already treats group.len() == 1 that way. The legend row itself needed rebuilding as plain-Rectangle entries with absolute-positioned children rather than nested HorizontalLayouts: Slint's flex-style distribution kept stretching each entry's label to fill the row's leftover width regardless of any horizontal-stretch set on the entry or a sibling spacer, stranding the remove button far from its label. Closes the "overlay group can be built but not taken apart" gap noted in PROJECT_PLAN.md. Claude-Session: https://claude.ai/code/session_01TMZB9qMKPv42o6XDYzdh4B
0x0Anna
force-pushed
the
overlay-dock-ungroup-control
branch
from
September 16, 2026 02:04
ba9944e to
18c3751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROJECT_PLAN.md: each entry in a merged dock's per-channel legend now has a small "×" that removes just that channel (graph::remove_channel_from_dock), collapsing the dock back to a plain single-channel one automatically once one remains.HorizontalLayouts for each legend entry let Slint's flex-style distribution stretch the label to fill leftover row width (this falls back to "treat all children as equally stretchy" whenever none of them individually claims a stretch, and it's evaluated separately at each nesting level). Rebuilt the legend row as plainRectangleentries with absolute-positioned children instead.Test plan
cargo build -p sde-appsucceedscargo test --workspacepasses (95 tests in sde-app, incl. 2 newremove_channel_from_dockunit tests; 0 failures workspace-wide)acr_motec_*.ldcapture): queued an overlay ofLB.pressure+LF.pressure, confirmed the legend renders tight (swatch, label, "×" per entry, no stray gap), and clicking one channel's "×" removes only that channel, collapsing the dock to a plainLF.pressure (bar)dock.