chore: Convert to Deno by ebebbington · Pull Request #17 · 0kku/destiny

ebebbington · 2021-06-03T00:09:41Z

Many changes:

Removes eslint, and uses deno lint instead
Option to use deno fmt is available
Removed all npm dependencies, and replaces scripts with scripts for deno
Creates a new compile.ts file, in place of tsc, which uses 2 unstable api's
Adds .ts extensions to imports for src instead of .js (to pass emit checks)
Remove tsconfig.json and package-lock.json as they are no longer needed
A new examples_mod.ts inside src so we can properly emit the examples. Reason for this is, they aren't part of the dependency free for mod.ts so aren't included in the emit result. Due to this, we compile examples_mod.ts too. Not worth compiling each individual file instead because that takes a long time. As it stands, running compile.ts is faster than tsc/webpack

Of course it's completely down to you @0kku, as to whether you want to request changes, let along approve this PR, it's all welcomed and i completely understand

So how do you, Okku, and an end user use destiny now?

Good question edward

As the maintainer of Destiny, you would:

Setup a webhook to deno.land, now anyone using Deno can import the src/*.ts files fine
npm run compile and deploy as you usually would this generates maps, declaration files and js files, so you can import it in the browser for js files

As a user of Destiny:

Import destiny from deno.land
or import destiny from the destiny cdn

TODO

Discuss examples directory: do we keep it as a test tool for @0kku? Do we migrate it into docs? (associated thread: chore: Convert to Deno #17 (comment))

compile.ts

0kku · 2021-06-05T21:59:51Z

src/styling/CSSTemplate.ts

@@ -1,3 +1,5 @@
+import "../globalTypes/CSSStyleSheet.ts"


Shouldn't this be import type?

Apparently import type is not supported without importing something specific. However, the way it is in its current form is not ideal, because it'll be importing this file even at runtime if it's not a type import.

This is more a way around using a globalThis.d.ts - it's just to include that type in the global scope

Saying this, where does it mention replace exists on CSSStyleSheet? Not the one ou define, but I remember you saying that the lib doesn't have it defined (yet) but it does exist, or something along those lines?

Saying this, where does it mention replace exists on CSSStyleSheet? Not the one ou define, but I remember you saying that the lib doesn't have it defined (yet) but it does exist, or something along those lines?

Here's the MDN page and here's some additional documentation.

The problem with import "./path" is that it shows up in the final compiled output, which is why type-only imports need to be imported with import type to avoid there being extraneous junk in the output.

Ok gotcha, looked through the code and can understand this better

I don't think importing it as a type is a possibility, and if you wanna avoid junk then i think the next best thing would be slapping a ts ignore on it :/ But ill keep thinking

Or another 'hack' would be modifying that global type file to just export an interface, and do something like:

// globaltypes/cssstylesheet.ts export intrface ICSSStyleSheet extends CSSStyleSheet { replace: (css: string) => void } // styling/CSSTemplate.ts import type { ICSSStyleSheet } from ... ... (this.#stylehsheet as ICSSStyleSheet).replace(this.cssText)

or do #stylesheet: ICSSStyleSheet | undefined instead (keeping the interface we import too)

Seems like doing the cast might be the least bad option.

ebebbington

formatting wasn't part of the project before, so remove this

ebebbington · 2021-06-03T08:28:06Z

package.json

-    "lint:code": "eslint src",
-    "lint:types": "tsc --noEmit",
+    "lint": "deno lint --ignore=dist",
+    "fmt": "deno fmt --ignore=dist",


remove this

Don't remove it yet, I'll have a look at what it looks like and see if it's useful to keep once I get some time.

0kku · 2021-07-01T04:08:39Z

Love the latest commit message lol.

…. woopsie daisy

compile.ts

ebebbington · 2021-07-01T14:29:18Z

examples/.gitignore

@@ -0,0 +1,3 @@
+node/package-lock.json


Purely making a note here so I remember to remove the examples directory - would be great if we could turn these into tutorials :)

Yeah honestly the examples don't make a ton of sense as part of the lib core, but that's where I run the tests, so I don't know if it's feasible to remove the examples completely 😬

It was more to help both us understand if it works for each environment :) After all we could turn the 'setups' into written tutorials

though i see what you mean...might be worth something to you, just maybe there's a better place to put these directories?

I might've actually misunderstood what you meant, my bad. Ignore my previous comment.

resolving, pr desc now includes a note about this

ebebbington · 2021-07-05T20:49:42Z

as of now, using canary (> 1.11.5) the infinite loop has gone, but revealed some more issues:

denoland/deno#11286
denoland/deno#11287

…s with bundle

ebebbington · 2021-07-06T11:13:22Z

3647b7f does address both issues mentioned above, though of course it is a tiny workaround

0kku · 2021-07-06T18:24:37Z

3647b7f does address both issues mentioned above, though of course it is a tiny workaround

Could've just moved the cleanup method outside the class, since it's doing nothing with the instance anyway.

ebebbington · 2021-07-06T18:40:14Z

3647b7f does address both issues mentioned above, though of course it is a tiny workaround

Could've just moved the cleanup method outside the class, since it's doing nothing with the instance anyway.

Guess that's your preferred way then :P Is this approach something you're ok with?

ebebbington · 2021-07-11T20:53:31Z

src/examples_mod.ts

+// Import some example files that aren't included in the dependency free, so we can compile them
+import "./_examples/main.ts"
+import "./_examples/components/visitor-demo.ts"
+import "./_examples/components/to-do/_to-do.ts"
+import "./_examples/components/array-demo.ts"
+import "./_examples/components/time-diff.ts"
+import "./_examples/components/async-demo.ts"
+import "./_examples/components/window-manager/_window-manager.ts"


Note about this file that i want to mention:

If instead of setting the path to the js file inside the tab-view.ts, we imported the class and passed it in, we wouldn't need the examples_mod.ts file, and would only need to emit _examples/main.ts, so for example:

// src/_examples/components/tab-view.ts import { AllComponents } from "all the files we need" class TabView { #tabs = [ { url: "/array-demo", component: ArrayDemo // before, it would be "./components/array-demo.js" } ] }

Of course the hash router would need to account for this.

Curious on your thoughts @0kku?

That would make it into a static import. It's intentionally dynamic: the component is not loaded until the user clicks on the tab. This makes initial load faster and avoids loading a potentially substantial number of pages that the user wasn't interested in visiting anyway. It's not a big deal on the example page because it's very small, but it's an example on how to do code splitting for a large website that could potentially have hundreds of large pages.

very very good point 👍

…use-deno2

ebebbington added 2 commits June 3, 2021 01:03

chore: Convert to Deno

bc16527

Merge branch 'master' into use-deno2

ad914aa

ebebbington commented Jun 3, 2021

View reviewed changes

compile.ts Outdated Show resolved Hide resolved

0kku reviewed Jun 5, 2021

View reviewed changes

ebebbington commented Jun 6, 2021

View reviewed changes

ebebbington added 2 commits June 6, 2021 14:45

Handle duplicate modify events for watcher

3198a15

Remove fmt from scripts

819868f

0kku marked this pull request as draft June 6, 2021 20:50

Cast stylesheet in CSSTemplate.ts

2f82977

ebebbington changed the title ~~chore: Convert to Deno~~ [DRAFT] chore: Convert to Deno Jun 7, 2021

ebebbington added 5 commits June 10, 2021 17:05

Use native Deno way of formatting diagnostics

306eb48

Merge branch 'master' into use-deno2

ffb7af1

fix compile.ts and src imports

c6a7022

add example of using destiny with node TMP

0423c8d

im sorry ok okku

85ebccd

ebebbington added 3 commits July 1, 2021 15:01

update examples, add browser example

c19747d

use crumpets

3360ced

remove files that were added in the merge, but not present in master.…

c24c328

…. woopsie daisy

ebebbington commented Jul 1, 2021

View reviewed changes

ebebbington added 4 commits July 1, 2021 21:04

few fixes

a8bba7d

Fix examples and watch

951a647

move examples imports into its own file to reduce dep tree

e80958e

dont use ws server when watching

ab230c8

ebebbington changed the title ~~[DRAFT] chore: Convert to Deno~~ chore: Convert to Deno Jul 1, 2021

ebebbington marked this pull request as ready for review July 1, 2021 20:58

Merge branch 'master' into use-deno2

082abc7

ebebbington added 2 commits July 6, 2021 10:56

improve deno examples

ccaedba

make some internal code adjustments to account for some minor problem…

3647b7f

…s with bundle

ebebbington added 7 commits July 6, 2021 12:22

add workflow

f46807e

add bumper workflow

fd7a0dd

remove loggin

c81cb90

deno lint

2538f28

remove dead code

4461918

correct compile.ts

018454f

correct examples readme

8d5c29f

ebebbington added 8 commits July 10, 2021 23:53

fix .d.ts file extensions

ff241b1

Update crumpets

bf2ffaa

once again, i am sorry okku

ac08c06

just for you okku

7782dc0

okku.includes(good suggestions) // true

60525bd

move tsconfig into its own file

a947c79

1:1 with master

2d0fbdf

remove package-lock.json

56adfaa

ebebbington commented Jul 11, 2021

View reviewed changes

ebebbington added 7 commits October 15, 2021 00:50

fixes nd remove hack

9369184

cleanup readme

efe1455

Merge branch 'master' of https://github.com/ebebbington/destiny into …

4179ddf

…use-deno2

rm examples dir

6bf424e

fmt

c034870

tidy up

34a35b8

correct workflow

b815a53

Conversation

ebebbington commented Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

So how do you, Okku, and an end user use destiny now?

TODO

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ebebbington Jun 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ebebbington left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0kku commented Jul 1, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ebebbington commented Jul 5, 2021

Uh oh!

ebebbington commented Jul 6, 2021

Uh oh!

0kku commented Jul 6, 2021

Uh oh!

ebebbington commented Jul 6, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ebebbington commented Jun 3, 2021 •

edited

Loading

ebebbington Jun 6, 2021 •

edited

Loading