Repository navigation
fix: prevent Sparkline shutdown race - #47
Merged
Merged
Conversation
- Subscribe to collection changes only while Sparkline is Loaded; detach on Unloaded and guard Redraw against unloaded visual access - Implement IAsyncDisposable on NavShellViewModel to snapshot/clear cache and start disposals concurrently; call Shell.DisposeAsync from MainWindow - Add tests covering Sparkline lifecycle and NavShell disposal ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
masterWinUI design by moving new dialogs and finite UI states into XAML-owned localization resources.build.ps1, Visual Studio/MSBuild, and MSIX builds through one shared PowerShell implementation.The earlier obfuscation implementation did not cover every build entry point. This PR unifies those paths while retaining master's XAML-first resource architecture and fixing the lifecycle failures found during review.
XOR is obfuscation rather than cryptographic secrecy because the binary contains both cipher and pad. The embedded key must remain scoped and rotatable.
Testing / 測試
go test ./...(fromengine/) — 388 tests passed in 21 packagesdotnet test app/JustHostMC.Core.Tests/JustHostMC.Core.Tests.csproj— 35 tests passedgo vet ./...dotnet build app/JustHostMC.App/JustHostMC.App.csproj -p:Platform=x64— 0 errors, 0 warningsclang-format;git diff --checkpassesCheck code formattingworkflow — passedScreenshots / 螢幕截圖
No before/after screenshots were captured. UI changes were validated through the x64 WinUI build and resource/finite-state tests, but not through a manual visual test pass.
Checklist / 檢查清單
proto/changed. / 若修改了proto/,我已在本機重新產生 protobuf 輸出。