Include filename in throw

[andrewcharnley]

var ast      = parser.parse(source, {
  ecmaVersion: 6,
  locations: true
});
} catch(e) {

    e.fileName = filename;
    throw e;
};

[BYK]

Good idea but not sure if this is really possible. May be eslint/espree does it. Are you willing to submit a pull request?

[andrewcharnley]

Why's it not possible? Just add e.fileName = filename;

Reason: the api.parse() takes a dataset and doesn't provide the specific item Acorn threw, instead just passing the Acorn error through.

I doubt linters are using Acorn? so potentially they can throw different errors.

[BYK]

Well that's true. I was a bit busy so didn't think long on this before replying. I'd much prefer the parser do this itself and Espree may be doing it. I'm already planning to switch to Espree sometime soon since it helps with handling comments so would simplify our code here.

So if you have the time I'd look into switching the parser to Espree instead of adding this try-catch block.