From 5a0a2c733a91b7804867f512fc260cbf568d5c47 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 30 Sep 2022 22:57:05 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- build_openwebtext_pretraining_dataset.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/build_openwebtext_pretraining_dataset.py b/build_openwebtext_pretraining_dataset.py index 5079c7e..1c1daa9 100644 --- a/build_openwebtext_pretraining_dataset.py +++ b/build_openwebtext_pretraining_dataset.py @@ -49,7 +49,26 @@ def log(*args): example_writer.n_written)) utils.rmkdir(job_tmp_dir) with tarfile.open(os.path.join(owt_dir, fname)) as f: - f.extractall(job_tmp_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(f, job_tmp_dir) extracted_files = tf.io.gfile.listdir(job_tmp_dir) random.shuffle(extracted_files) for txt_fname in extracted_files: From 9dc7240a674f9d63c13a9ea6e8dc4ba686f777e4 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 01:08:15 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- build_openwebtext_pretraining_dataset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_openwebtext_pretraining_dataset.py b/build_openwebtext_pretraining_dataset.py index 1c1daa9..7a8490f 100644 --- a/build_openwebtext_pretraining_dataset.py +++ b/build_openwebtext_pretraining_dataset.py @@ -65,7 +65,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(f, job_tmp_dir)