From b8d6cde2a857498fc9c06162dc858de9bf5dc227 Mon Sep 17 00:00:00 2001 From: Martin Molzer Date: Thu, 9 Apr 2026 00:35:36 +0200 Subject: [PATCH 1/3] lint also on wasm32 target --- .github/workflows/clippy.yml | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index 62ef8c6fa46..b8be16b8650 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -41,21 +41,16 @@ jobs: - uses: taiki-e/install-action@cargo-hack - name: Lint feature soundness - if: matrix.profile == 'dev' + env: + RELEASE_FLAG: ${{ case(matrix.profile == 'release', '--release', null) }} run: >- cargo hack clippy -p yew -p yew-agent -p yew-router --feature-powerset --no-dev-deps --keep-going - -- -D warnings - - - name: Lint feature soundness - if: matrix.profile == 'release' - run: >- - cargo hack clippy - -p yew -p yew-agent -p yew-router - --feature-powerset --no-dev-deps - --keep-going --release + $RELEASE_FLAG + --target `rustc --version --verbose | sed -n 's/host: //p'` + --target wasm32-unknown-unknown -- -D warnings clippy: From 2e84eb594f1eb1c8e019c4304160f32f5a4200c7 Mon Sep 17 00:00:00 2001 From: Martin Molzer Date: Thu, 9 Apr 2026 00:40:37 +0200 Subject: [PATCH 2/3] add wasm32 target to toolchain --- .github/workflows/clippy.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index b8be16b8650..a7e6aa9eaab 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -33,6 +33,7 @@ jobs: with: toolchain: stable components: clippy + targets: wasm32-unknown-unknown - uses: Swatinem/rust-cache@v2 with: From a13d1113ae31aa4c7033ea9e5bbf09205476b0e4 Mon Sep 17 00:00:00 2001 From: Martin Molzer Date: Thu, 9 Apr 2026 00:51:59 +0200 Subject: [PATCH 3/3] make target a matrix dimension --- .github/workflows/clippy.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clippy.yml b/.github/workflows/clippy.yml index a7e6aa9eaab..f25d21553c7 100644 --- a/.github/workflows/clippy.yml +++ b/.github/workflows/clippy.yml @@ -25,6 +25,9 @@ jobs: profile: - dev - release + target: + - host + - wasm32 steps: - uses: actions/checkout@v6 @@ -33,7 +36,7 @@ jobs: with: toolchain: stable components: clippy - targets: wasm32-unknown-unknown + targets: ${{ case(matrix.target == 'wasm32', 'wasm32-unknown-unknown', null) }} - uses: Swatinem/rust-cache@v2 with: @@ -44,14 +47,14 @@ jobs: - name: Lint feature soundness env: RELEASE_FLAG: ${{ case(matrix.profile == 'release', '--release', null) }} + TARGET_FLAGS: ${{ case(matrix.target == 'wasm32', '--target wasm32-unknown-unknown', null) }} run: >- cargo hack clippy -p yew -p yew-agent -p yew-router --feature-powerset --no-dev-deps --keep-going $RELEASE_FLAG - --target `rustc --version --verbose | sed -n 's/host: //p'` - --target wasm32-unknown-unknown + $TARGET_FLAGS -- -D warnings clippy: