Where: scripts/check_em_dash.py's ALLOWLIST, the faircode/significance.py entry.
The gap: the entry's comment reads # Frozen for the paper (CLAUDE.md §1) - must not be modified, even cosmetically. CLAUDE.md now states the paper freeze is lifted and faircode/ core is "open to normal development again" - so this allowlist entry's own justification is no longer true, while the file it excuses genuinely contains two em dashes that would otherwise fail the repo's own style rule.
Repro: removing the allowlist entry and running the checker directly against the file:
$ python3 -c "
import re
text = open('faircode/significance.py', encoding='utf-8').read()
print('em dash count:', text.count('—'))
"
em dash count: 2
Both are in significance.py's own module docstring (lines 8 and 14), describing the bootstrap CI and permutation test.
Why it matters: the CI em-dash check is silently skipping a real, currently-violating file based on a justification (a paper freeze) that policy says is no longer in effect - the exact kind of "comment cites an outdated policy" drift this repo has caught and fixed multiple times elsewhere (e.g. the paper-freeze-lifted sweep across README/CONTRIBUTING/CONTRIBUTORS/ROADMAP).
Suggested fix: remove the faircode/significance.py allowlist entry and fix its two em dashes (straightforward - they're in prose, not any frozen numeric/logic content), or, if there's still a real reason to leave this file untouched that isn't the paper freeze, update the comment to say so accurately.
Where:
scripts/check_em_dash.py'sALLOWLIST, thefaircode/significance.pyentry.The gap: the entry's comment reads
# Frozen for the paper (CLAUDE.md §1) - must not be modified, even cosmetically.CLAUDE.md now states the paper freeze is lifted andfaircode/core is "open to normal development again" - so this allowlist entry's own justification is no longer true, while the file it excuses genuinely contains two em dashes that would otherwise fail the repo's own style rule.Repro: removing the allowlist entry and running the checker directly against the file:
Both are in
significance.py's own module docstring (lines 8 and 14), describing the bootstrap CI and permutation test.Why it matters: the CI em-dash check is silently skipping a real, currently-violating file based on a justification (a paper freeze) that policy says is no longer in effect - the exact kind of "comment cites an outdated policy" drift this repo has caught and fixed multiple times elsewhere (e.g. the paper-freeze-lifted sweep across README/CONTRIBUTING/CONTRIBUTORS/ROADMAP).
Suggested fix: remove the
faircode/significance.pyallowlist entry and fix its two em dashes (straightforward - they're in prose, not any frozen numeric/logic content), or, if there's still a real reason to leave this file untouched that isn't the paper freeze, update the comment to say so accurately.