Now that #8221 has been merged, I've drafted the two following notes (edits welcome) that I think need to be included for popover and the popover target attributes sections:
for popover:
The popover attribute is a global attribute to allow authors flexibility in ensuring popover functionality can be applied to the most appropriate semantic element which represents the content of the popover. Authors can use the popover attribute on generic elements, such as div, or author defined custom elements, but it will generally be recommended that authors also ensure proper accessibility semantics are also provided to these generic elements, by also specifying the appropriate ARIA roles and properties.
for the popover target attributes section:
To help ensure a popover will be programmatically exposed in a logical reading order to users of assistive technology, it is strongly recommended for most use cases that authors include their popover following its triggering element in the DOM.
in addition to the above note, I'd also want to adjust the examples to also reflect this guidance. The popover ideally would come after the button element. Additionally, at least one of the examples would also use a non-generic element (a list or an article, for example). Maybe one of the examples could also have an ARIA role to match the guidance of the note. If we want to leave one of the examples as is, I'd be happy to include another to demonstrate this, instead.
I'm happy to make the PR for this, but would just request any preferences as to where these notes (particularly the one i mentioned as being for the popover attribute) would best fit in the flow of each section's content.
cc @mfreed7, @josepharhar, @aleventhal, @domenic
Thanks
Now that #8221 has been merged, I've drafted the two following notes (edits welcome) that I think need to be included for popover and the popover target attributes sections:
for
popover:for the popover target attributes section:
in addition to the above note, I'd also want to adjust the examples to also reflect this guidance. The popover ideally would come after the button element. Additionally, at least one of the examples would also use a non-generic element (a list or an article, for example). Maybe one of the examples could also have an ARIA role to match the guidance of the note. If we want to leave one of the examples as is, I'd be happy to include another to demonstrate this, instead.
I'm happy to make the PR for this, but would just request any preferences as to where these notes (particularly the one i mentioned as being for the
popoverattribute) would best fit in the flow of each section's content.cc @mfreed7, @josepharhar, @aleventhal, @domenic
Thanks