Skip to content

FileSystemObserver should support Symbol.dispose #178

@mitranim

Description

@mitranim

What problem are you trying to solve?

Manual cleanup is easy to forget. try/finally requires nesting. Cleanup with using is more convenient.

What solutions exist today?

const obs = new FileSystemObserver(myCallback)
await obs.observe(handle)
try {/* Various activities. */}
finally {obs.disconnect()}

How would you solve it?

// This should be built-in.
const pro = FileSystemObserver.prototype
if (!pro[Symbol.dispose]) {
  const desc = Object.getOwnPropertyDescriptor(pro, `disconnect`)
  Object.defineProperty(pro, Symbol.dispose, desc)
}

using obs = new FileSystemObserver(myCallback)
await obs.observe(handle)
/* Various activities. */

Metadata

Metadata

Assignees

No one assigned

    Labels

    addition/proposalNew features or enhancementsneeds implementer interestMoving the issue forward requires implementers to express interest

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions