Skip to content

Google Sheets Integration imports non-existant credentials.js file causing ERR_MODULE_NOT_FOUND #61

Description

@jetpham

While I was testing the CLI and ran node packages/playground/dist/index.js run end --mock --input '{"message":"done"}' and got ERR_MODULE_NOT_FOUND due to packages/nodes/dist/integrations/types/credentials.js. This seems to be introduces because we are importing this file but it doesn't exist. The PR that added this was #54. This seems to have been missed by the unit tests googleSheetsAppendNode, googleSheetsReadNode, googleSheetsUpdateNode, and googleSheetsClearNode because they do not test the credential definition file. There are no end-to-end integration tests for this node and since it doesn't actually use any credentials to do a test it didn't catch this. There should be some better integration tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions