From 9d962f73c69c242f0db482297ab3d1b636337330 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Wed, 25 Jan 2023 11:53:27 -0800 Subject: [PATCH] Check popover stack when buttons are modified The popover stack is constructed by attributes set on buttons. When those buttons are modified, it can break connections in the stack. This patch adds checks to spots where buttons can be modified in order to fix up the list by closing all popovers when a connection has been broken. This patch also moves the disabled check for popover*target attributes which Anne asked for here: https://github.com/whatwg/html/pull/8221#discussion_r1049379113 Bug: 1307772, 1408546 Change-Id: I129cf2768abc717292b86ea26f7522019ce36d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4115790 Commit-Queue: Joey Arhar Reviewed-by: Mason Freed Cr-Commit-Position: refs/heads/main@{#1096920} --- ...ver-target-element-disabled.tentative.html | 126 ++++++++++++++++++ 1 file changed, 126 insertions(+) create mode 100644 html/semantics/popovers/popover-target-element-disabled.tentative.html diff --git a/html/semantics/popovers/popover-target-element-disabled.tentative.html b/html/semantics/popovers/popover-target-element-disabled.tentative.html new file mode 100644 index 00000000000000..3d139c5950eb6b --- /dev/null +++ b/html/semantics/popovers/popover-target-element-disabled.tentative.html @@ -0,0 +1,126 @@ + + + + + + +
+ +
+
popover
+ + +
+ +
+
popover
+ + +
+ +
+
popover
+ + +
+ +
+
popover
+
form
+ + +
+ toggle popover +
+
popover
+ + +
+ +
+
popover
+