UploadFile Widget Type does not show currently existing value

[dlee1579]

UploadFile widget allows file upload on a CharField, but it does not show a currently existing value (if a file has already been uploaded). Can this be adjusted to show an existing value?

[vsdudakov]

Good catch. I will take a look.

[dlee1579]

Thank you!

Another thing I noticed. Examples of the upload_file functionality have field_name, file_name, and file_content as parameters. How do we update the actual object's char field, if the object itself is not passed in as an argument?

In my mind I had an idea of something like this

async def upload_file(
    self,
    obj,
    field_name,
    file_name,
    file_content
):
    # file upload logic here

    update_dict = {
        field_name: file_name,
    }
    obj.update_from_dict(update_dict)
    await obj.save()
    return file_name

Am I understanding the usage of upload_file() properly?

[vsdudakov]

We don't need to update it here. The upload_file function is only for uploading a file and returning the file url for the UploadFile widget on the frontend. Then you click save on admin and save this path to the field.

By the way, you probably just need to return the full file URL instead of the file name, and it will fix this issue.

I will improve the documentation related to this functionality.

@dlee1579

[vsdudakov]

Enhanced examples here https://github.com/vsdudakov/fastadmin/releases/tag/0.4.8

[dlee1579]

@vsdudakov the issue I am having with the upload_file method is that, per the documentation, this is where I should implement upload to S3. When doing so, I want to upload this file to somewhere in S3 like s3_bucket/<object-id>/file.pdf where the path of this file is specific to the object being saved.

With the current way that upload_file() is set up, I do not have access to the object id, so I cannot upload directly to the S3 location that I want. I'd have to save it either locally or somewhere in S3 like s3_bucket/file.pdf, then overwrite the save_model() method to then copy this object over to the appropriate destination, THEN delete the file in the original public location.

Is this the intended behavior?

[vsdudakov]

@dlee1579 Got you! Makes sense. Okay, I will update the logic and provide obj as an optional parameter or with id None for create page case but with filename and so on (because for create page it is None until we save the object).

[dlee1579]

Thank you! I am currently working off of version 0.4.0 because upload_file() seems to be the last version that supported this pattern:

0.3.11...0.4.0#diff-d5b1a7f860dd9fa8de96c1abb8098b535915bf9ed80d4608031e225e4302ece4R80

[vsdudakov]

#130 - on review

[vsdudakov]

Fixed here https://github.com/vsdudakov/fastadmin/releases/tag/0.4.9