From 508a8341134da8cf6eac6621c4698b8d69d5a736 Mon Sep 17 00:00:00 2001 From: Polichinl Date: Wed, 24 Jun 2026 11:15:12 +0200 Subject: [PATCH] chore(naming): align Layer-1 target fixture ged_sb_best -> lr_ged_sb (#49) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #49 described the target as `lr_*_best`, which does not exist in this repo. The real Layer-1 target-name straggler is `ged_sb_best` (3x in test_views_frames_conformance.py), which the canonical (views-models#151) and this repo's own ADR-011 doc map to `lr_ged_sb`. Rename those 3; the Layer-2 delivery column `pred_ln_sb_best` is left untouched (explicitly out of scope). Synthetic test label only — no logic change; suite green. Closes #49. Co-Authored-By: Claude Opus 4.8 --- tests/test_views_frames_conformance.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test_views_frames_conformance.py b/tests/test_views_frames_conformance.py index 4700904..1ecf68f 100644 --- a/tests/test_views_frames_conformance.py +++ b/tests/test_views_frames_conformance.py @@ -35,7 +35,7 @@ def _frame(months=(100, 101), gids=(1, 2, 3)): return pd.DataFrame( { "pred_ln_sb_best": rng.gamma(2.0, 1.0, size=len(rows)), - "ged_sb_best": rng.integers(0, 50, size=len(rows)), + "lr_ged_sb": rng.integers(0, 50, size=len(rows)), }, index=idx, ) @@ -72,12 +72,12 @@ def test_values_come_from_the_named_column(self): class TestTargetFrameConformance: def test_satisfies_frame_contract(self): - tf = to_target_frame(_frame(), "ged_sb_best") + tf = to_target_frame(_frame(), "lr_ged_sb") assert_frame_contract(tf) def test_observed_actuals_shape(self): df = _frame() - tf = to_target_frame(df, "ged_sb_best") + tf = to_target_frame(df, "lr_ged_sb") assert isinstance(tf, TargetFrame) assert tf.n_rows == len(df) assert tf.values.shape == (len(df), 1)