From 30d042992e589de0b457a59b3d93f2a9e64f50d0 Mon Sep 17 00:00:00 2001 From: "Sergei Kalugin (Work iMac)" Date: Tue, 25 Apr 2017 11:58:33 -0500 Subject: [PATCH 1/3] Removes unnecessary variable declaration. --- jquery.tabslet.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jquery.tabslet.js b/jquery.tabslet.js index 26df420..f8ab47a 100644 --- a/jquery.tabslet.js +++ b/jquery.tabslet.js @@ -59,7 +59,7 @@ } }; - var options = $.extend(defaults, options); + options = $.extend(defaults, options); return this.each(function() { From 99016c93d2e91c0ad5b1db52e45fdce81d6f09ab Mon Sep 17 00:00:00 2001 From: "Sergei Kalugin (Work iMac)" Date: Tue, 25 Apr 2017 11:59:55 -0500 Subject: [PATCH 2/3] Changes comparison syntax to avoid unexpected type coercion. --- jquery.tabslet.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jquery.tabslet.js b/jquery.tabslet.js index f8ab47a..9d3fd17 100644 --- a/jquery.tabslet.js +++ b/jquery.tabslet.js @@ -138,7 +138,7 @@ i = ++i % elements.length; // wrap around - $this.opts.mouseevent == 'hover' ? elements.eq(i).trigger('mouseover') : elements.eq(i).click(); + $this.opts.mouseevent === 'hover' ? elements.eq(i).trigger('mouseover') : elements.eq(i).click(); if ($this.opts.autorotate) { @@ -196,9 +196,9 @@ var move = function(direction) { - if (direction == 'forward') i = ++i % elements.length; // wrap around + if (direction === 'forward') i = ++i % elements.length; // wrap around - if (direction == 'backward') i = --i % elements.length; // wrap around + if (direction === 'backward') i = --i % elements.length; // wrap around elements.eq(i).click(); From 2cfa6a1613ff3d7d62fcd7673d42b15e5e410dba Mon Sep 17 00:00:00 2001 From: "Sergei Kalugin (Work iMac)" Date: Tue, 25 Apr 2017 12:03:36 -0500 Subject: [PATCH 3/3] Cosmetic edits. --- jquery.tabslet.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/jquery.tabslet.js b/jquery.tabslet.js index 9d3fd17..3a9fff7 100644 --- a/jquery.tabslet.js +++ b/jquery.tabslet.js @@ -128,9 +128,11 @@ ); - var init = eval("elements." + $this.opts.mouseevent + "(fn)"); + var init = function() { + eval("elements." + $this.opts.mouseevent + "(fn)"); + }; - init; + init(); var t; @@ -154,7 +156,7 @@ } - } + }; if ($this.opts.autorotate) { @@ -202,7 +204,7 @@ elements.eq(i).click(); - } + }; $this.find(options.controls.next).click(function() { move('forward'); @@ -234,9 +236,7 @@ $(this).removeAttr('style').css( 'display', _cache_div[i] ); }); }); - } - }); };