Skip to content

Security fixes, type safety, and tooling improvements #13

@rahulvalyu

Description

@rahulvalyu

Summary

Audit identified security vulnerabilities, broken tooling, and type safety issues that need to be resolved.

Issues

Security

  • Command injection in browser.tsexec() with unsanitized URL input allows arbitrary shell command execution
  • Credential file permissionscredentials.json created with default 0644 permissions, readable by all users on shared systems

Type Safety

  • 5 TypeScript type errorspnpm typecheck fails (unsafe casts, missing paused status in union type, incompatible markedTerminal type)

Tooling

  • Biome 2.x config brokenbiome.json uses deprecated v1.x keys (organizeImports, files.ignore), linter cannot run
  • Lint auto-fixes — template literals, import sorting, unused imports

Reliability

  • Infinite polling in contents command — async job handler has no timeout, can hang forever
  • Hardcoded User-Agentvalyu-cli/1.0.0 hardcoded in 4 places instead of using VERSION constant

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions