-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Summary
Audit identified security vulnerabilities, broken tooling, and type safety issues that need to be resolved.
Issues
Security
- Command injection in
browser.ts—exec()with unsanitized URL input allows arbitrary shell command execution - Credential file permissions —
credentials.jsoncreated with default 0644 permissions, readable by all users on shared systems
Type Safety
- 5 TypeScript type errors —
pnpm typecheckfails (unsafe casts, missingpausedstatus in union type, incompatiblemarkedTerminaltype)
Tooling
- Biome 2.x config broken —
biome.jsonuses deprecated v1.x keys (organizeImports,files.ignore), linter cannot run - Lint auto-fixes — template literals, import sorting, unused imports
Reliability
- Infinite polling in contents command — async job handler has no timeout, can hang forever
- Hardcoded User-Agent —
valyu-cli/1.0.0hardcoded in 4 places instead of usingVERSIONconstant
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels