I'm concerned about this file. It may be out of scope for this PR, but a "constants" file should only be for GLOBAL constants that CANNOT be owned by any other scoping-mechanism (like other modules, classes, etc). Many of these constants do not seem global and should probably be reviewed to be moved into more relevant contexts.
Of course, I'm very aware that I could be missing information that explains why it makes sense for these to be global and unscoped.
Originally posted by @CrazyKidJack in #72 (comment)
I'm concerned about this file. It may be out of scope for this PR, but a "constants" file should only be for GLOBAL constants that CANNOT be owned by any other scoping-mechanism (like other modules, classes, etc). Many of these constants do not seem global and should probably be reviewed to be moved into more relevant contexts.
Of course, I'm very aware that I could be missing information that explains why it makes sense for these to be global and unscoped.
Originally posted by @CrazyKidJack in #72 (comment)