From 8c069d8286a0d93586f3ab14a8b10f71604b9d1b Mon Sep 17 00:00:00 2001 From: Anil Anar Date: Fri, 22 May 2026 19:58:42 +0200 Subject: [PATCH 1/2] revert(messenger-internal): roll back #60 (re-applied in next commit) Companion to the next commit. PR #60's original commit (4c1b7dc) used the non-conventional 'internal:' type prefix that release-please does not recognize, so the fix has been sitting on master unreleased. We can't just push an empty conventional-commit marker because GitHub's merge strategies drop empty commits. Workaround: revert here, re-apply with the right message in the next commit. Net code change on master: zero. --- packages/messenger-internal/src/loader/load-scripts.ts | 2 +- packages/messenger-internal/src/loader/types.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/messenger-internal/src/loader/load-scripts.ts b/packages/messenger-internal/src/loader/load-scripts.ts index 8c7651e..5b62f63 100644 --- a/packages/messenger-internal/src/loader/load-scripts.ts +++ b/packages/messenger-internal/src/loader/load-scripts.ts @@ -30,7 +30,7 @@ export function loadScripts( addScriptSrc(contentDocument, manifest[lastIdx], () => { const { run }: Window & { run: Run } = unsafeCoerce(contentWindow); - run({ widget_key: widgetKey, base_url: baseUrl }, window) + run({ widget_key: widgetKey }, window) .then((widgetLoader) => resolve(widgetLoader)) .catch(reject); }); diff --git a/packages/messenger-internal/src/loader/types.ts b/packages/messenger-internal/src/loader/types.ts index 3ce64ba..ef7922d 100644 --- a/packages/messenger-internal/src/loader/types.ts +++ b/packages/messenger-internal/src/loader/types.ts @@ -53,7 +53,6 @@ export interface LegacyOptions { export interface RunSettings { widget_key: string; - base_url?: string; } export type Run = ( From 7cb92cf8dc6a5705616156a57b42f1380dc45379 Mon Sep 17 00:00:00 2001 From: Anil Anar Date: Fri, 22 May 2026 19:59:35 +0200 Subject: [PATCH 2/2] fix(messenger-internal): pass base_url through to run() (#60) Re-applies the change originally landed in 4c1b7dc (#60) on 2026-05-13 with a conventional-commit subject so release-please picks it up. The previous commit on this branch reverts the change; this one re-applies it. Net code change on master: zero. The diff is identical to 4c1b7dc's diff. Original change: makes baseUrl available so the messenger bundle knows which origin served its loader. Backwards compatible: baseUrl is optional. Existing umm bundles ignore the new field; bundles that read it fall back to their env-baked URL when older messenger-internal omits it. --- packages/messenger-internal/src/loader/load-scripts.ts | 2 +- packages/messenger-internal/src/loader/types.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/messenger-internal/src/loader/load-scripts.ts b/packages/messenger-internal/src/loader/load-scripts.ts index 5b62f63..8c7651e 100644 --- a/packages/messenger-internal/src/loader/load-scripts.ts +++ b/packages/messenger-internal/src/loader/load-scripts.ts @@ -30,7 +30,7 @@ export function loadScripts( addScriptSrc(contentDocument, manifest[lastIdx], () => { const { run }: Window & { run: Run } = unsafeCoerce(contentWindow); - run({ widget_key: widgetKey }, window) + run({ widget_key: widgetKey, base_url: baseUrl }, window) .then((widgetLoader) => resolve(widgetLoader)) .catch(reject); }); diff --git a/packages/messenger-internal/src/loader/types.ts b/packages/messenger-internal/src/loader/types.ts index ef7922d..3ce64ba 100644 --- a/packages/messenger-internal/src/loader/types.ts +++ b/packages/messenger-internal/src/loader/types.ts @@ -53,6 +53,7 @@ export interface LegacyOptions { export interface RunSettings { widget_key: string; + base_url?: string; } export type Run = (