From a400d2f7c53cafd56adfa4c68868d2eebd56d0c3 Mon Sep 17 00:00:00 2001 From: Andrew Baxter <> Date: Wed, 25 Mar 2026 18:22:46 +0900 Subject: [PATCH 1/3] Build on pr; fix lint --- .github/workflows/docker.yml | 5 ++--- src/explicitcast/explicitcast.go | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 84b412c..7b40697 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -1,8 +1,6 @@ name: ci on: push: - tags: - - "v*" jobs: main: runs-on: ubuntu-latest @@ -22,7 +20,8 @@ jobs: registry: ghcr.io username: ${{ github.actor }} password: ${{ secrets.GH_PUBLISH_DEVREL }} - - uses: docker/build-push-action@v5 + - if: ${{ startsWith(github.ref, 'refs/tags/v') }} + uses: docker/build-push-action@v5 with: context: "{{defaultContext}}:src" push: true diff --git a/src/explicitcast/explicitcast.go b/src/explicitcast/explicitcast.go index a4c9476..1f63413 100644 --- a/src/explicitcast/explicitcast.go +++ b/src/explicitcast/explicitcast.go @@ -142,7 +142,7 @@ func New() *analysis.Analyzer { if inFunc == nil { t := strings.Builder{} for i, c := range crumbs { - t.WriteString(fmt.Sprintf("crumb %d %T %s\n", i, c, p.Fset.Position(c.Pos()))) + fmt.Fprintf(t, "crumb %d %T %s\n", i, c, p.Fset.Position(c.Pos())) } panic("ASSERTION!" + p.String() + "\n" + t.String()) } From 66fc24d3e1bc3287e2882d0bdafe0392db8611a7 Mon Sep 17 00:00:00 2001 From: Andrew Baxter <> Date: Wed, 25 Mar 2026 18:38:09 +0900 Subject: [PATCH 2/3] Still do build --- .github/workflows/docker.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 7b40697..2c11fdb 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -15,14 +15,14 @@ jobs: tags: | type=semver,pattern={{version}} - uses: docker/setup-buildx-action@v3 - - uses: docker/login-action@v3 + - if: ${{ startsWith(github.ref, 'refs/tags/v') }} + uses: docker/login-action@v3 with: registry: ghcr.io username: ${{ github.actor }} password: ${{ secrets.GH_PUBLISH_DEVREL }} - - if: ${{ startsWith(github.ref, 'refs/tags/v') }} - uses: docker/build-push-action@v5 + - uses: docker/build-push-action@v5 with: context: "{{defaultContext}}:src" - push: true + push: ${{ startsWith(github.ref, 'refs/tags/v') }} tags: ${{ steps.dockermeta.outputs.tags }} From 902bca8c51473b2e40092ee8e2f526e8db99a6c6 Mon Sep 17 00:00:00 2001 From: Andrew Baxter <> Date: Wed, 25 Mar 2026 18:40:28 +0900 Subject: [PATCH 3/3] Fix fprintf --- src/explicitcast/explicitcast.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/explicitcast/explicitcast.go b/src/explicitcast/explicitcast.go index 1f63413..64824f2 100644 --- a/src/explicitcast/explicitcast.go +++ b/src/explicitcast/explicitcast.go @@ -142,7 +142,7 @@ func New() *analysis.Analyzer { if inFunc == nil { t := strings.Builder{} for i, c := range crumbs { - fmt.Fprintf(t, "crumb %d %T %s\n", i, c, p.Fset.Position(c.Pos())) + fmt.Fprintf(&t, "crumb %d %T %s\n", i, c, p.Fset.Position(c.Pos())) } panic("ASSERTION!" + p.String() + "\n" + t.String()) }