Skip to content

fix(useTableNames): prevent mutation of title interpolation props #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unusual-enterprise wants to merge 1 commit into
base: 11.x
Choose a base branch
from
+15 −9
Open

fix(useTableNames): prevent mutation of title interpolation props #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions vue/src/js/hooks/table/useTableNames.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,21 @@ export default function useTableNames(props, context) {
translationKey = props.editFormTitle
}

let interpolation = isEditing ? props.formEditTitleInterpolations : props.formCreateTitleInterpolations

for(let key in interpolation) {
let value = interpolation[key]
interpolation[key] = __isset(Module[interpolation[key]])
? Module[interpolation[key]].value
: __isset(editedItem.value[interpolation[key]])
? editedItem.value[interpolation[key]]
: value
// NOTE: Build a fresh object — never mutate `props.form{Edit,Create}TitleInterpolations`.
// The source map holds *paths* (e.g. `{ item: 'id' }`); writing the resolved value back into
// it would poison the next compute, since the loop would then look up the resolved value
// itself (e.g. a UUID) instead of the original path — pinning the modal title to the id of
// the first ticket opened in the session.
const interpolationSource = isEditing ? props.formEditTitleInterpolations : props.formCreateTitleInterpolations
const interpolation = {}

for(let key in interpolationSource) {
const path = interpolationSource[key]
interpolation[key] = __isset(Module[path])
? Module[path].value
: __isset(editedItem.value[path])
? editedItem.value[path]
: path
}

return te(translationKey) ? t(translationKey, interpolation) : translationKey
Expand Down
Loading