feat: add session structure to impersonation functionality#356
Open
celikerde wants to merge 3 commits into
Open
feat: add session structure to impersonation functionality#356celikerde wants to merge 3 commits into
celikerde wants to merge 3 commits into
Conversation
unusual-enterprise
changed the title
- Added functionality to track recently impersonated users, limiting the count to a maximum of 5. - Introduced a new method `pushRecentImpersonation` to manage the recent impersonation stack in the session. - Updated the ImpersonateToolbar component to accept a `recent` prop for displaying recent impersonations. These changes enhance the user experience by allowing easy access to recently impersonated users.
…sonations retrieval - Refactored the `get_modularous_impersonation_config` function to improve readability by introducing variables for active and impersonating states. - Added a new function `get_modularous_recent_impersonations` to retrieve recently impersonated users from the session, enhancing the impersonation tracking feature. - This update improves the structure and maintainability of the impersonation logic while providing better access to recent impersonation data.
- Introduced a new `recentItems` prop to the Browser component, allowing users to see recently accessed items. - Implemented logic to display recent items when no other results are available, improving the default view of the dialog. - Added a visual indicator for recent items in the list, enhancing usability and clarity for users. - Updated the search behavior to reset to recent items when the search input is cleared, ensuring a seamless user experience.
celikerde
force-pushed
the
feat/add-session-structure-to-impersonation-functionality
branch
from
dce7db8 to
94793ac
Compare
oguzhanbukcuoglu
approved these changes
Jun 8, 2026
oguzhanbukcuoglu
left a comment
oguzhanbukcuoglu
left a comment
Collaborator
There was a problem hiding this comment.
It's good, but it might conflict with changes at #360, so be careful at the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Types of changes
Description
Related Issue