From 48d08cd137a89538e6d821cc44c13d1568ea8ec8 Mon Sep 17 00:00:00 2001 From: Chris Hunt Date: Fri, 27 Apr 2018 15:18:57 -0400 Subject: [PATCH] Remove unused members from GraphiteReporter. The build was failing when using Clang 7 due to unused members in `GraphiteReporter` and `-Wall,-Werror` being configured in `CMakeLists.txt`. Example output: ``` ... [ 87%] Building CXX object CMakeFiles/cppmetrics.dir/src/cppmetrics/graphite/graphite_reporter.o [ 93%] Building CXX object CMakeFiles/cppmetrics.dir/src/cppmetrics/core/console_reporter.o In file included from ./src/cppmetrics/graphite/graphite_reporter.cpp:20: ./src/cppmetrics/graphite/graphite_reporter.h:90:33: error: private field 'rate_unit_' is not used [-Werror,-Wunused-private-field] boost::chrono::milliseconds rate_unit_; ^ ./src/cppmetrics/graphite/graphite_reporter.h:91:33: error: private field 'duration_unit_' is not used [-Werror,-Wunused-private-field] boost::chrono::milliseconds duration_unit_; ^ 2 errors generated. ``` --- src/cppmetrics/graphite/graphite_reporter.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/cppmetrics/graphite/graphite_reporter.h b/src/cppmetrics/graphite/graphite_reporter.h index d2ce1b2..6e7f38e 100644 --- a/src/cppmetrics/graphite/graphite_reporter.h +++ b/src/cppmetrics/graphite/graphite_reporter.h @@ -87,8 +87,6 @@ class GraphiteReporter: public core::ScheduledReporter, boost::noncopyable { core::MetricRegistryPtr registry_; GraphiteSenderPtr sender_; std::string prefix_; - boost::chrono::milliseconds rate_unit_; - boost::chrono::milliseconds duration_unit_; }; } /* namespace graphite */