Creation of Configuration Component#19
Open
GerritBurgerDev wants to merge 5 commits into
Open
Conversation
GerritBurgerDev
commented
Jan 28, 2022
| @@ -0,0 +1,11 @@ | |||
| .mat-slide-toggle.mat-checked { | |||
Collaborator
Author
There was a problem hiding this comment.
Didn't quite know where to add this global overwrite so I made a new file for it? Should we rather have a material.scss file for all global angular material overwrites? @ubergeoff
GerritBurgerDev
commented
Jan 28, 2022
| <ng-container *ngIf="!!configComponent"> | ||
| <div | ||
| class="config-sliders" | ||
| rooiComponentConfig |
Collaborator
Author
There was a problem hiding this comment.
Allows for each example/component to have it's own configuration component
GerritBurgerDev
commented
Jan 28, 2022
| styleUrls: ['./component-configuration.component.scss'] | ||
| }) | ||
| export class ComponentConfigurationComponent { | ||
| @Input() title: string | undefined; |
Collaborator
Author
There was a problem hiding this comment.
for some reason ESLint wants these | undefined types. I don't like it though, should I update the eslint rules?
GerritBurgerDev
commented
Jan 28, 2022
| @@ -0,0 +1,36 @@ | |||
| <div class="config-container"> | |||
Collaborator
Author
There was a problem hiding this comment.
Not the most detailed example, but Angular Material's updating is sub-par tbh
GerritBurgerDev
commented
Jan 28, 2022
| constructor(private matTableDemoService: MatTableDemoService) {} | ||
|
|
||
| toggleRowExpansion(): void { | ||
| this.componentConfiguration.enableRowExpansion = !this.componentConfiguration.enableRowExpansion; |
Collaborator
Author
There was a problem hiding this comment.
To be updated. Angular Material table needs a force update to make this work. Do you know how to externally force an update?
GerritBurgerDev
commented
Jan 28, 2022
| constructor(private matTableDemoService: MatTableDemoService) { | ||
| this.rowComponent = MatTableRowDemoComponent; | ||
| this.expandedRowComponent = MatTableExpansionRowDemoComponent; | ||
| // this.expandedRowComponent = MatTableExpansionRowDemoComponent; |
Collaborator
Author
There was a problem hiding this comment.
To be removed
Owner
|
@GerritBurgerDev - Failing build..? Need some help..? |
Collaborator
Author
|
Hey sorry got a little hectic first week will jump on it on Monday
…On Fri, 04 Feb 2022, 10:18 ubergeoff, ***@***.***> wrote:
@GerritBurgerDev <https://github.com/GerritBurgerDev> - Failing build..?
Need some help..?
—
Reply to this email directly, view it on GitHub
<#19 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHFN2SL763G72U2JSBHKDFLUZODU5ANCNFSM5M5JKI3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.