You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Non-blocking concerns raised while reviewing PR #295 (fix(finicky): open github.com deep links in the GitHub PWA).
None of these blocked the merge. They are batched into one issue so a
review's findings stay one unit of attention rather than 2 separate
tracking issues; tick items off as they are addressed, and close this issue
when the list is done or the remaining items are judged not worth doing.
Removing non-GitHub PWA handlers drops dedicated app routing for Google Workspace and work tools (claude (automated blocking review), finicky/finicky.js:handlers)
The reviewer noted that the meet, calendar, gmail, drive, docs, sheets, slides, qualio, rippling, rootly and datadog handlers were removed, and that those URLs now fall through to defaultBrowser (Google Chrome) instead of their dedicated PWAs. The config comment states the reason: a handler naming an uninstalled app drops the URL rather than falling back. If any of those PWAs are installed later, the handlers need to be restored using the new --app-id form, not the old bundle-ID form. Worth tracking so the regression in routing is deliberate rather than forgotten.
github.com subdomains no longer route to the GitHub PWA (claude (automated blocking review), finicky/finicky.js — matchHostnames for the github handler)
The match changed from ["github.com", /\.github\.com$/] to ["github.com", "www.github.com"]. The inline comment says this is deliberate because Chrome only honors the launch URL when the URL is inside the PWA's scope, and reports that an out-of-scope URL such as gist.github.com opens the PWA at its start page and loses the link. Subdomains now fall through to Chrome. Track in case a future Chrome or Finicky version handles out-of-scope launch URLs differently, or if a wider PWA scope makes subdomain routing viable again.
Non-blocking concerns raised while reviewing PR #295 (fix(finicky): open github.com deep links in the GitHub PWA).
None of these blocked the merge. They are batched into one issue so a
review's findings stay one unit of attention rather than 2 separate
tracking issues; tick items off as they are addressed, and close this issue
when the list is done or the remaining items are judged not worth doing.
Removing non-GitHub PWA handlers drops dedicated app routing for Google Workspace and work tools (claude (automated blocking review),
finicky/finicky.js:handlers)The reviewer noted that the meet, calendar, gmail, drive, docs, sheets, slides, qualio, rippling, rootly and datadog handlers were removed, and that those URLs now fall through to
defaultBrowser(Google Chrome) instead of their dedicated PWAs. The config comment states the reason: a handler naming an uninstalled app drops the URL rather than falling back. If any of those PWAs are installed later, the handlers need to be restored using the new--app-idform, not the old bundle-ID form. Worth tracking so the regression in routing is deliberate rather than forgotten.github.com subdomains no longer route to the GitHub PWA (claude (automated blocking review),
finicky/finicky.js — matchHostnames for the github handler)The match changed from
["github.com", /\.github\.com$/]to["github.com", "www.github.com"]. The inline comment says this is deliberate because Chrome only honors the launch URL when the URL is inside the PWA's scope, and reports that an out-of-scope URL such as gist.github.com opens the PWA at its start page and loses the link. Subdomains now fall through to Chrome. Track in case a future Chrome or Finicky version handles out-of-scope launch URLs differently, or if a wider PWA scope makes subdomain routing viable again.