Install fails with Node v23, due to `-std=c++17`.

[magnusriga]

Would it be possible to update binding.gyp, from -std=c++17 to -std=c++20 (or higher)?

A minimum of C++20 is required in Node 23:

https://github.com/nodejs/node/blob/9d2368f64329bf194c4e82b349e76fdad879d32a/deps/v8/include/v8config.h#L13

Without it, building tree-sitter will fail.

[gpetrov]

this should be easily solved in changing in binding.gyp all c++17 to c++20 @amaanq

[segevfiner]

But note that upgrading the C++ std version can prevent usage with older OS/compilers and versions of Node.js... This is something/another thing Node.js/v8 doesn't handle that well IMHO...

[KeqingMoe]

I forked and released my own version, which fixes existing issues and works fine. I hope it helps.

https://www.npmjs.com/package/@keqingmoe/tree-sitter

[Abrifq]

Hi, I don't know which older node versions you support but for these parts:

node-tree-sitter/binding.gyp

Lines 27 to 47 in c84d48d

	"cflags_cc": [
	"-std=c++17"
	],
	"conditions": [
	["OS=='mac'", {
	"xcode_settings": {
	"GCC_SYMBOLS_PRIVATE_EXTERN": "YES", # -fvisibility=hidden
	"CLANG_CXX_LANGUAGE_STANDARD": "c++17",
	"MACOSX_DEPLOYMENT_TARGET": "10.9",
	},
	}],
	["OS=='win'", {
	"msvs_settings": {
	"VCCLCompilerTool": {
	"AdditionalOptions": [
	"/std:c++17",
	],
	"RuntimeLibrary": 0,
	},
	},
	}],

Why don't you just use the default configuration from node's common.gypi?
If you use that, the nodejs install will supply the c++ version.

[Abrifq]

Why don't you just use the default configuration from node's common.gypi?
If you use that, the nodejs install will supply the c++ version.

Nevermind, looks like node doesn't have a proper version in their config.gypi and common.gypi.

[Abrifq]

Nevermind, looks like node doesn't have a proper version in their config.gypi and common.gypi.

😅
I realized I could run a diff between versions... and yeah, there is a difference: node_module_version variable changes across versions!

nodejs version	node_module_version
22	127
23	131
24	137

I didn't notice before because I was looking between 22 & 24, which had only one digit change. Sorry!