From c1935c4b8121b097ad254cb4356c1216d0e37f56 Mon Sep 17 00:00:00 2001 From: MICHAEL SHORTREED Date: Sat, 20 Jun 2026 15:39:43 -0500 Subject: [PATCH] ci: fail-soft on Codecov upload and fix coverage path The Build and Test job failed on all open PRs (#116, #117, #118) because the final Codecov step errored on upload (exit 4294967295) while fail_ci_if_error was true, marking the whole job failed even though restore, build, and tests all passed (235 passed, 0 failed). - fail_ci_if_error: true -> false so a Codecov-side hiccup no longer fails the build - fix coverage file path: coverage.net6.0.xml -> coverage.xml to match the Coverlet output (/p:CoverletOutput='../../coverage.xml') - bump checkout/setup-dotnet/codecov-action v3 -> v4 to clear the Node 20 deprecation warnings Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/dotnet.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index c153c1f..97e2716 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -11,11 +11,11 @@ jobs: runs-on: windows-latest timeout-minutes: 15 steps: - - uses: actions/checkout@v3 - with: + - uses: actions/checkout@v4 + with: fetch-depth: 10 - name: Setup .NET - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4 with: dotnet-version: 6.x - name: Restore dependencies @@ -30,9 +30,9 @@ jobs: /p:CollectCoverage=true /p:CoverletOutputFormat=cobertura /p:CoverletOutput='../../coverage.xml' - name: Codecov - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@v4 with: token: ${{ secrets.CODECOV }} verbose: true - files: ./coverage.net6.0.xml - fail_ci_if_error: true + files: ./coverage.xml + fail_ci_if_error: false