Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

make docker-ci improvements #163

Description

  • 1. performance of mount folders on a macos host https://docs.docker.com/docker-for-mac/osxfs-caching/ --- use :cached
  • 2. at times, there will be platform-dependent dependencies, and then it doesn't make sense to mount the whole repo (you'll need to make nuke deps build inside docker, and then once again outside docker, when finished). You might be good to go mounting the repo/.git folder instead of running git checkout . inside docker. This way, still have access to the whole git history, but you have a separate checkout instance
  • 3. proxy variables likes AWS_* or GH_TOKEN from the host to the docker container
  • 4. make docker-ci needs to be followed by a ./.ci.sh before_install to install required system dependencies, plus it can take a long time to create GIDs and do recursive chown, etc so ideally there would be a make docker-ci/scratch and make docker-ci where the latter would actually make use of an existing local image based on SF_DOCKER_CI_IMAGE + GIDs/etc + ./.ci.sh before_install

cc Simon Schlegel (@spschlegel)
cc Fredrik Öhrström (@weetmuts) no 4 would be the intermediary step for creating repo-based docker images

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions