Skip to content

chore: post-envcar tidy - unused LoadFromEnv, strings.ReplaceAll #38

Description

@tobert

Minor cleanups noticed while implementing #33.

  • w3c/traceparent.LoadFromEnv has no production callers now that config_span.go reads the env carrier through envcar (otelcli/propagation.go:envCarrierTraceparent). Only its own unit test calls it. Decide: keep as a documented w3c/traceparent utility, or deprecate/remove.
  • otelcli/exec.go: strings.Replace(arg, "{{traceparent}}", ..., -1)strings.ReplaceAll(...) (staticcheck QF1004). Trivial, pre-existing.

Low priority; bundle into a future propagation PR (e.g. #34).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions