Skip to content

Commit ffdf324

Browse files
committed
tests: use testify for testing
1 parent f604eda commit ffdf324

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

internal/utils/string_utils_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,29 +61,29 @@ func TestCompileUserEmail(t *testing.T) {
6161
func TestParseNonEmptyLines(t *testing.T) {
6262
lines := utils.ParseNonEmptyLines(" first@example.com \n\n second@example.com \n \n")
6363

64-
assert.DeepEqual(t, []string{"first@example.com", "second@example.com"}, lines)
64+
assert.Equal(t, []string{"first@example.com", "second@example.com"}, lines)
6565
}
6666

6767
func TestGetStringList(t *testing.T) {
6868
file, err := os.Create("/tmp/tinyauth_list_test_file")
69-
assert.NilError(t, err)
69+
assert.NoError(t, err)
7070

7171
_, err = file.WriteString(" third@example.com \n\n fourth@example.com \n")
72-
assert.NilError(t, err)
72+
assert.NoError(t, err)
7373

7474
err = file.Close()
75-
assert.NilError(t, err)
75+
assert.NoError(t, err)
7676
defer os.Remove("/tmp/tinyauth_list_test_file")
7777

7878
values, err := utils.GetStringList([]string{" first@example.com ", "", "second@example.com"}, "/tmp/tinyauth_list_test_file")
79-
assert.NilError(t, err)
80-
assert.DeepEqual(t, []string{"first@example.com", "second@example.com", "third@example.com", "fourth@example.com"}, values)
79+
assert.NoError(t, err)
80+
assert.Equal(t, []string{"first@example.com", "second@example.com", "third@example.com", "fourth@example.com"}, values)
8181

8282
values, err = utils.GetStringList(nil, "")
83-
assert.NilError(t, err)
84-
assert.DeepEqual(t, []string{}, values)
83+
assert.NoError(t, err)
84+
assert.Equal(t, []string{}, values)
8585

8686
values, err = utils.GetStringList(nil, "/tmp/non_existing_list_file")
8787
assert.ErrorContains(t, err, "no such file or directory")
88-
assert.DeepEqual(t, []string{}, values)
88+
assert.Equal(t, []string{}, values)
8989
}

internal/utils/user_utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ func ParseUsers(usersStr []string, userAttributes map[string]model.UserAttribute
1313
var users []model.LocalUser
1414

1515
if len(usersStr) == 0 {
16-
return &users, nil
16+
return nil, nil
1717
}
1818

1919
for _, user := range usersStr {

0 commit comments

Comments
 (0)