Repeating Thundermail Calendar Events Cutting Off Last Day

[madhattermattic]

Describe the bug

I have a user that is setting repeated events in Thundermail calendar that last two, three, five days strait. However, those show up in Appointment after syncing as one, two, and four days only, cutting the last repeating day off.

Perhaps it's related to time zones?

To Reproduce

Steps to reproduce the behavior:

1. Set a repeating event in Thundermail calendar that lasts more than two days
2. Wait for that event to sync to Appointment
3. View how many days on the calendar the repeating event happens

Expected behavior

All repeated days should be included

Actual behavior

The final day in the series does not show up in Appointment after sync

Screenshots

(Ticket 5516)

gz#5516

[lisajill]

@madhattermattic In your reproduction, was this aesthetic only? Or did it impact availability? e.g. were people able to book into what would should have been blocked day/times?

[madhattermattic]

@lisajill Apologies, I should have mentioned in this request that I was unable to reproduce, that's my mistake, I see now that I didn't mention that above. These screenshots and replication steps are directly from the user.

I was unable to reproduce - Appointment works as expected for me, but that may be due to my time zone if the hunch is correct.

The user's calendar was able to be booked on the days that did not end up with the last day in the sequence - The events did not set for the full amount of days, they all ended up one day short. However, interestingly, single day events in the future set to the calendar just fine.

[madhattermattic]

The user says this is still happening for them and has added two more screenshots to show their system time zone and calendar settings, if that helps:

[madhattermattic]

We've got some more clues here that seem to point to a time zone problem, not sure since I cannot recreate this. I'm going to directly quote the user on this next bit:

"Regarding the All Day events, I have attached some screen shots. The All Day event does appear in tb.pro if on my client for the Event I set: Options - Show time as - Busy. It defaults to Free so then it does not appear in tb.pro:"

"In tb.pro the highlight start time for the all day event is 10am even though the day starts at 6am:"

"Also, the highlighted block extends well after the end of day at 11pm:"

[madhattermattic]

Additionally, there is a bug that I can reproduce just as described, on an all-day event. This is in their words:

"When you hover the mouse cursor over the all day event, the small event summary info box is displayed as expected, however that info box cannot be seen if you scroll your Appointment window to the top and THEN hover the mouse cursor over it - the info box has scrolled down the bottom of the window out of sight:"

"If you can see the info box and you keep your mouse within the highlighted appointment slot then you can scroll up and down and not lose the info box."

[davinotdavid]

@madhattermattic thanks for relaying all the info! Really appreciate it 🙏

I believe we have a couple of different things here. The all-day event handling is something that will be handled in two different issues:

1. All day events overflow the Dashboard calendar UI #1702 will be a fix for the all day event block overflowing the calendar UI. Seems to be a bit more straightforward / easier to fix so that has been separated into its own issue.

2. All day events should be aggregated at the top row in the calendar UI #1703 will be a larger effort since we unfortunately haven't implemented the all day event as the Design team intended. These should be aggregated to the top instead of a block that spans vertically for the whole day.

I was also not able to reproduce the original issue of the off-by-one events, though. Perhaps @devmount would be able to check on this timezone? I will also continue trying to reproduce here!

[devmount]

Yes, I'll try to reproduce that here in Europe/Berlin

[devmount]

I finally got time to come back to this issue, sorry for the delay 🙏🏻

I was able to create a fix for one issue I could reproduce that is related to this report in #1715. However, I wasn't able to reproduce the original issue in my timezone either. I tested various different variations for repeated events (different lengths, repetition by max date, repetition by max count).

gz#5516