Skip to content

revertOnFailure parameter is not used in deploy() #1479

@RawanMostafa08

Description

@RawanMostafa08

https://github.com/threefoldtech/tfgrid-sdk-go/blob/development/grid-client/deployer/deployer.go#L109
the revertOnFailure parameter is not used in deploy(), while the logic here depends on it

I think it's safe to just remove the parameter, as Deploy() is the one handling the revert logic by sending the oldDeployments as the target state if revert is true.

Metadata

Metadata

Assignees

No one assigned

    Labels

    grid-clientbelongs to grid client

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions