Skip to content

Commit 39746dc

Browse files
Merge pull request #6 from testdevlab/remote_fix
Remote fix
2 parents 8f4cfdb + 001567a commit 39746dc

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

testui/support/appium_driver.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -235,22 +235,26 @@ def start_driver(desired_caps, url, debug, port, udid, log_file):
235235

236236

237237
def start_selenium_driver(desired_caps, url=None, debug=None, browser=None, chrome_options=None, firefox_options=None):
238+
options = chrome_options
239+
if firefox_options is not None:
240+
options = firefox_options
241+
242+
if options is not None:
243+
logger.log("setting options: " + options.to_capabilities())
244+
238245
logger.log("setting capabilities: " + desired_caps.__str__())
239246
logger.log(f"starting selenium {browser.lower()} driver...")
240247
err = None
241248
for x in range(2):
242249
try:
243250
if url is not None:
244-
options = chrome_options
245-
if firefox_options is not None:
246-
options = firefox_options
247251

248252
driver = webdriver.Remote(url, desired_caps, options=options)
249253
else:
250254
if browser is None:
251-
driver = webdriver.Chrome(desired_capabilities=desired_caps, chrome_options=chrome_options)
255+
driver = webdriver.Chrome(desired_capabilities=desired_caps, chrome_options=options)
252256
elif browser.lower() == 'firefox':
253-
driver = webdriver.Firefox(firefox_options=firefox_options, desired_capabilities=desired_caps)
257+
driver = webdriver.Firefox(firefox_options=options, desired_capabilities=desired_caps)
254258
elif browser.lower() == 'safari':
255259
driver = webdriver.Safari(desired_capabilities=desired_caps)
256260
elif browser.lower() == 'edge':

0 commit comments

Comments
 (0)