[Maven-Bundle-Plugin]Generate Manifest when a maven project is added

[apupier]

currently it is generated when a dependency is modified:

m2eclipse-tycho/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/felix/internal/MavenBundlePluginConfigurator.java

Lines 322 to 323 in 08cafef

	if ( MavenProjectChangedEvent.KIND_CHANGED == event.getKind()
	&& MavenProjectChangedEvent.FLAG_DEPENDENCIES == event.getFlags() )

In case of import of a pre-configured Maven project in a new workspace (with .project), we need to listen to MavenProjectChangedEvent.KIND_ADDED too

[apupier]

for reference, issue discovered while working on https://issues.jboss.org/browse/FUSETOOLS-2183

[apupier]

@fbricon can you have a look please?

[apupier]

seems my first was not right. It was fixing the issue "sometimes" only.

What I observed today for the project attached in https://issues.jboss.org/browse/FUSETOOLS-2183 :

• the MANIFEST.MF is first generated
• then the JavaBuilder is cleaning some folders, including target/classes/META-INF
  see org.eclipse.jdt.internal.core.builder.BatchImageBuilder.cleanOutputFolders(boolean)

I'm able to workaround it by adding a check if the target/classes/META-INF/MANIFEST.MF exists when calculating the "generate" boolean:

m2eclipse-tycho/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/felix/internal/MavenBundlePluginConfigurator.java

Lines 108 to 118 in 08cafef

	boolean generate = IncrementalProjectBuilder.FULL_BUILD == kind;
	// the property is set by OsgiBundleProjectConfigurator.mavenProjectChanged is a workaround for
	// m2e design limitation, which does not allow project configurators trigger resource deltas
	// visible to build participants. See comment in OsgiBundleProjectConfigurator.mavenProjectChanged
	generate =
	generate || Boolean.parseBoolean( (String) project.getSessionProperty( PROP_FORCE_GENERATE ) );
	// reset FORCE flag so we don't regenerate forever
	project.setSessionProperty( PROP_FORCE_GENERATE, null );
	generate = generate || isIncludeBndFileChange( buildContext, instructions );

I'm not able to reproduce the issue with a simple project, neither programmatically.