Skip to content

Commit d540ccb

Browse files
committed
🔒 Keep this slice's Deno-only suites out of the Node and Bun corpora
Four suites this branch adds open a real `node:sqlite` WorkflowRun database through the Deno storage adapter, and none of them had an exclusion entry. Bun has no `node:sqlite` at all, so it would have loaded them and failed on the import. They had entries before #293 was cut into a stack. The manifest is one shared file and each slice was built by applying a set of paths to a fresh branch, so it took whichever branch's version was applied last rather than accumulating — the suites moved and their entries did not. `runtime-exclusions.test.ts` cannot catch this. It checks that every entry names a file discovery finds; it has no way to know which suites are Deno-only, so a missing entry looks exactly like a portable test. What does catch it is asking what the runner would run: derive the corpus the way `runtimeTests` does, subtract the exclusions, and walk each survivor's imports for `node:sqlite`. That reports zero here, and reported these four before. Refs #293
1 parent 638a92c commit d540ccb

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

‎scripts/runtime-test-exclusions.ts‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,30 @@ const DENO_ONLY_TOOLING: RuntimeExclusion[] = [
144144
"kills real Deno child processes with SIGKILL and reads the recovered node:sqlite WorkflowRun database they leave behind; the children run under the Deno executable and node:sqlite remains behind --experimental-sqlite on Node 22",
145145
issue: "https://github.com/taras/executable.md/issues/365",
146146
},
147+
{
148+
path: "packages/workflow/tests/repository-components.test.ts",
149+
reason:
150+
"drives <Repository> and <Dir> against a real node:sqlite WorkflowRun database, the Deno DOFS Workspace adapter and a real `git` subprocess; Bun has no node:sqlite at all and Node 22 keeps it behind --experimental-sqlite",
151+
issue: "https://github.com/taras/executable.md/issues/293",
152+
},
153+
{
154+
path: "packages/workflow/tests/repository-storage.test.ts",
155+
reason:
156+
"clones local bare repositories with a real `git` into the Deno DOFS Workspace and reads the retained node:sqlite rows back; the provider is the Deno one by design",
157+
issue: "https://github.com/taras/executable.md/issues/293",
158+
},
159+
{
160+
path: "packages/workflow/tests/repository-replay.test.ts",
161+
reason:
162+
"replays a partial node:sqlite WorkflowRun after deleting the remote and every host materialization, and halts a real blocked `git` child; both the store and the subprocess are the Deno adapter's",
163+
issue: "https://github.com/taras/executable.md/issues/293",
164+
},
165+
{
166+
path: "packages/workflow/tests/repository-materialization.test.ts",
167+
reason:
168+
"exports retained checkouts to host directories and links their roots at external clones, against a real node:sqlite WorkflowRun database",
169+
issue: "https://github.com/taras/executable.md/issues/293",
170+
},
147171
{
148172
path: "packages/workflow/tests/materialization.test.ts",
149173
reason:

0 commit comments

Comments
 (0)