Commit abaa1ee
authored
Two things the corpus runner got wrong about the engine (#20)
The corpus itself was right the whole way: 1438 cases, 1438 passed, 0
failed, 0 unsupported against the engine at main. What was red was two
things beside it.
The test for a case ahead of the engine used SELECT 1 as a statement the
engine has not reached, and the engine reaches it: SELECT is a statement
head in ISO 39075 and this engine parses one, so the case came back with
a column called 1 and the runner correctly called that a failure rather
than an unsupported. It is CREATE NODE TABLE now, which the engine
refuses with 42001 and the words "CREATE is not implemented yet". A test
like this is a canary by construction and the comment now says so: the
day CREATE lands it has to pick another spelling.
The javadoc on Cell said {@link #equals}, and Cell is a sealed interface
that declares no equals, so the reference did not resolve and the
release profile failed on it. It points at Object#equals(Object), which
is the method the records generate an override of and the one the
sentence is about.
Verified on a Linux box against the engine at 55382df: the corpus module
is BUILD SUCCESS with RunnerTest 12 of 12, and mvn -P release -DskipTests
package is BUILD SUCCESS.1 parent 4b05b01 commit abaa1ee
2 files changed
Lines changed: 17 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
228 | 233 | | |
229 | 234 | | |
230 | 235 | | |
231 | 236 | | |
232 | 237 | | |
233 | 238 | | |
234 | | - | |
| 239 | + | |
235 | 240 | | |
236 | 241 | | |
237 | 242 | | |
| |||
0 commit comments