From 899ccbcd7bda13b4d734cae767c9af671f3e3f27 Mon Sep 17 00:00:00 2001 From: Ryan Yocum Date: Fri, 20 Feb 2026 12:13:46 -0500 Subject: [PATCH] Move to 1 byte crc --- src/ER_V/api_demo.c | 4 ++-- src/ER_V/main.cpp | 2 +- src/Ichor/main.cpp | 2 +- src/common/api/api.cpp | 3 +-- src/common/socket/socket.cpp | 4 ++-- 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/ER_V/api_demo.c b/src/ER_V/api_demo.c index 77f70ed..14e428c 100644 --- a/src/ER_V/api_demo.c +++ b/src/ER_V/api_demo.c @@ -69,7 +69,7 @@ int main() { LOG_INFO("Staring demo..."); // Setup buffers - uint16_t byte_len = sizeof(API_Data_Header) + sizeof(API_Data_Polar_Pan) + 2; + uint16_t byte_len = sizeof(API_Data_Header) + sizeof(API_Data_Polar_Pan) + 1; uint8_t bytes[byte_len]; memset(&bytes[0], 0, byte_len); char text[UTIL_BYTE_STR_FMT_LEN(byte_len)]; @@ -95,4 +95,4 @@ int main() { LOG_INFO("Demo Ending..."); LOG_stop(); LOG_destroy(); -} \ No newline at end of file +} diff --git a/src/ER_V/main.cpp b/src/ER_V/main.cpp index b96e05f..c4ada79 100644 --- a/src/ER_V/main.cpp +++ b/src/ER_V/main.cpp @@ -58,7 +58,7 @@ static void dummy_msg(Subscriber* hermes) { cmd->delay_ms = 0; - buf->len = sizeof(API_Data_Home) + sizeof(API_Data_Header) + 2; + buf->len = sizeof(API_Data_Home) + sizeof(API_Data_Header) + 1; hermes->EnqueueBuffer(SUB_QUEUE_COMMAND, buf); } #endif diff --git a/src/Ichor/main.cpp b/src/Ichor/main.cpp index 29094eb..fced849 100644 --- a/src/Ichor/main.cpp +++ b/src/Ichor/main.cpp @@ -63,7 +63,7 @@ static void dummy_msg(Subscriber* hermes) { cmd->delay_ms = 0; - buf->len = sizeof(API_Data_Home) + sizeof(API_Data_Header) + 2; + buf->len = sizeof(API_Data_Home) + sizeof(API_Data_Header) + 1; hermes->EnqueueBuffer(SUB_QUEUE_COMMAND, buf); } #endif diff --git a/src/common/api/api.cpp b/src/common/api/api.cpp index d345dfb..0f53f9e 100644 --- a/src/common/api/api.cpp +++ b/src/common/api/api.cpp @@ -71,8 +71,7 @@ int validate_command(const uint8_t* buf, uint16_t len) { // Check CRC // TODO: Implement - uint16_t* crc = (uint16_t*)(&cmd->payload_head + cmd->header.len); - *crc = be16toh(*crc); + uint8_t* crc = (uint8_t*)(&cmd->payload_head + cmd->header.len); return 0; } diff --git a/src/common/socket/socket.cpp b/src/common/socket/socket.cpp index 4f55d3b..037a4e2 100644 --- a/src/common/socket/socket.cpp +++ b/src/common/socket/socket.cpp @@ -114,10 +114,10 @@ void Socket::poll() { buf_iter += ret; - while (buf_iter >= sizeof(API::DataHeader) + 2) { + while (buf_iter >= sizeof(API::DataHeader) + 1) { auto* msg = reinterpret_cast(buffer.data()); uint16_t total_len = - sizeof(API::DataHeader) + be16toh(msg->header.len) + 2; + sizeof(API::DataHeader) + be16toh(msg->header.len) + 1; if (buf_iter < total_len) break; if (!props_.sub) {