feat: Add finding dismissal flow#19
Merged
Merged
Conversation
Support dismissing Superagent findings from trusted review-thread replies and resolved conversations, using P0-P3 labels consistently across comments and checks.
Contributor License AgreementThe following contributors need CLA coverage:
|
superagent-security
Bot
added
the
contributor:verified
superagent-security
Bot
added
the
pr:flagged
Only prior contributors or users with write-level access can dismiss findings; PR authorship alone no longer grants dismissal trust.
![superagent-security[bot]](https://avatars.githubusercontent.com/in/3287076?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a finding dismissal flow for Superagent PR scans. Trusted contributors can dismiss findings by replying with sufficient context on the inline finding thread or by resolving the GitHub review conversation, and the Security scan is cleared once every finding has been addressed.
Also updates finding display from severity labels to P0-P3 across PR comments, inline review comments, check summaries, and scanner guidance.
Fixes #
Checklist
Test plan
npm test -- src/lib/__tests__/findingPriority.test.ts src/services/__tests__/findingDismissal.test.ts src/services/__tests__/prFindings.test.ts src/services/__tests__/trustedContributor.test.ts src/services/__tests__/comments.test.ts src/services/__tests__/prScan.test.tsnpm run typechecksuperagent-ai/argus-hackerPR #33: resolving the single Superagent finding thread emittedDismissed finding from resolved threadand changed Security scan to success.