refactor(renderer): remove dead pinned-overlay scroll short-circuit (#463)

* refactor(renderer): remove dead pinned-overlay scroll short-circuit

* fix: another case

* chore: simplify

* chore: dead code

* chore: is_new_part seems not needed here

* chore: cleanup

Author: phanen

lua/opencode/state/store.lua

@@ -61,7 +61,7 @@ local _state = {
   pre_zoom_width = nil,
   last_window_width_ratio = nil,
   last_sent_context = nil,
-  current_context_config = {},
+  current_context_config = nil,
   context_updated_at = nil,
   active_session = nil,
   restore_points = {},

lua/opencode/state/ui.lua

@@ -268,7 +268,7 @@ function M.get_window_cursor(win_id)
     return nil
   end
 
-  return normalize_cursor(pos)
+  return pos
 end
 
 ---@param win_type 'input'|'output'

lua/opencode/types.lua

@@ -316,7 +316,7 @@
 ---@field capture_streamed_events boolean
 ---@field show_ids boolean
 ---@field highlight_changed_lines boolean
----@field highlight_changed_lines_timeout_ms number
+---@field highlight_changed_lines_timeout_ms integer
 ---@field quick_chat {keep_session: boolean, set_active_session: boolean}
 
 ---@alias OpencodeCommandLifecycleStage 'before'|'after'|'error'|'finally'

lua/opencode/ui/formatter.lua

@@ -285,9 +285,7 @@ function M.format_message_header(message, previous_message)
     local current_mode = message.info.mode or state.current_mode
     same_mode_as_previous = previous_role == 'assistant'
       and current_mode
-      and previous_mode
       and current_mode ~= ''
-      and previous_mode ~= ''
       and current_mode == previous_mode
   end
 

lua/opencode/ui/input_window.lua

@@ -133,10 +133,6 @@ function M.handle_submit()
 
   local input_content = table.concat(vim.api.nvim_buf_get_lines(windows.input_buf, 0, -1, false), '\n')
   vim.api.nvim_buf_set_lines(windows.input_buf, 0, -1, false, {})
-  vim.api.nvim_exec_autocmds('TextChanged', {
-    buffer = windows.input_buf,
-    modeline = false,
-  })
 
   if input_content == '' then
     return false

lua/opencode/ui/output.lua

@@ -1,29 +1,15 @@
 local config = require('opencode.config')
 
-local Output = {}
-Output.__index = Output
-
 ---@class Output
 ---@field lines string[]
 ---@field extmarks table<number, OutputExtmark[]>
 ---@field actions OutputAction[]
 ---@field targets OutputTarget[]
----@field add_line fun(self: Output, line: string, fit?: boolean): number
----@field get_line fun(self: Output, idx: number): string?
----@field merge_line fun(self: Output, idx: number, text: string)
----@field add_lines fun(self: Output, lines: string[], prefix?: string)
----@field add_empty_line fun(self: Output): number?
----@field clear fun(self: Output)
----@field get_line_count fun(self: Output): number
----@field get_lines fun(self: Output): string[]
----@field add_extmark fun(self: Output, idx: number, extmark: OutputExtmark|fun(): OutputExtmark)
----@field get_extmarks fun(self: Output): table<number, table[]>
----@field add_actions fun(self: Output, actions: OutputAction[])
----@field add_action fun(self: Output, action: OutputAction)
----@field get_actions_for_line fun(self: Output, line: number): OutputAction[]?
----@field add_target fun(self: Output, target: OutputTarget)
----@field add_targets fun(self: Output, targets: OutputTarget[])
----@return self Output
+---@field fold_ranges {from: integer, to: integer}[]
+local Output = {}
+Output.__index = Output
+
+---@return Output
 function Output.new()
   local self = setmetatable({}, Output)
   self.lines = {}

lua/opencode/ui/output_window.lua

@@ -627,13 +627,12 @@ function M.highlight_changed_lines(start_line, end_line)
   local last = math.max(first, end_line)
 
   vim.api.nvim_buf_clear_namespace(buf, M.debug_namespace, first, last + 1)
-  for line = first, last do
-    vim.api.nvim_buf_set_extmark(buf, M.debug_namespace, line, 0, {
-      line_hl_group = 'OpencodeChangedLines',
-      hl_eol = true,
-      priority = 250,
-    })
-  end
+  vim.api.nvim_buf_set_extmark(buf, M.debug_namespace, first, 0, {
+    end_row = last,
+    line_hl_group = 'OpencodeChangedLines',
+    hl_eol = true,
+    priority = 250,
+  })
 
   vim.defer_fn(function()
     if vim.api.nvim_buf_is_valid(buf) then

lua/opencode/ui/permission_window.lua

@@ -103,15 +103,15 @@ end
 
 ---Update permission from message part data
 ---@param permission_id string
----@param part table
+---@param part OpencodeMessagePart
 ---@return boolean
 function M.update_permission_from_part(permission_id, part)
   if not permission_id or not part then
     return false
   end
 
   local permission = nil
-  for i, existing in ipairs(M._permission_queue) do
+  for _, existing in ipairs(M._permission_queue) do
     if existing.id == permission_id then
       permission = existing
       break
@@ -244,7 +244,7 @@ function M.format_display(output)
     title = icons.get('warning') .. ' Permission Required' .. progress,
     title_hl = 'OpencodePermissionTitle',
     border_hl = 'OpencodePermissionBorder',
-    content = render_content and nil or content,
+    content = content,
     render_content = render_content,
     options = options,
     unfocused_message = 'Focus Opencode window to respond to permission',

lua/opencode/ui/render_state.lua

@@ -212,12 +212,9 @@ end
 ---@param message_id string
 ---@return RenderedMessage?
 function RenderState:get_previous_message(messages, message_id)
-  for i = #messages, 1, -1 do
+  for i = #messages, 2, -1 do
     local message = messages[i]
     if message and message.info and message.info.id == message_id then
-      if i <= 1 then
-        return nil
-      end
       local previous_message = messages[i - 1]
       return previous_message and previous_message.info and self._messages[previous_message.info.id] or nil
     end

lua/opencode/ui/renderer/events.lua

@@ -380,7 +380,7 @@ function M.on_part_updated(properties, revert_index)
   local is_new_part = not part_data
 
   local prev_last_part_id = get_last_part_for_message(message)
-  local existing_part_index = nil
+  local existing_part_index = nil ---@type integer?
   for i = #message.parts, 1, -1 do
     if message.parts[i].id == part.id then
       existing_part_index = i
@@ -391,7 +391,7 @@ function M.on_part_updated(properties, revert_index)
   -- Preserve state.input when the update omits it. MCP tool completion
   -- events sometimes arrive with an empty input table, clobbering the
   -- call arguments from the earlier running event.
-  if part.state and part.state.input and type(part.state.input) == 'table' and next(part.state.input) == nil then
+  if part.state and type(part.state.input) == 'table' and next(part.state.input) == nil then
     local old_input = nil
     if existing_part_index then
       old_input = message.parts[existing_part_index]
@@ -407,24 +407,7 @@ function M.on_part_updated(properties, revert_index)
   end
 
   -- Update the part reference in the message
-  if is_new_part then
-    if existing_part_index then
-      message.parts[existing_part_index] = part
-    else
-      table.insert(message.parts, part)
-    end
-  else
-    if existing_part_index then
-      message.parts[existing_part_index] = part
-    else
-      for i = #message.parts, 1, -1 do
-        if message.parts[i].id == part.id then
-          message.parts[i] = part
-          break
-        end
-      end
-    end
-  end
+  message.parts[existing_part_index or #message.parts + 1] = part
 
   if part.type == 'step-start' or part.type == 'step-finish' then
     if part.type == 'step-finish' and part.tokens then