From ff2c4b0444a9d4f7079567dbd610572e86a6ffc7 Mon Sep 17 00:00:00 2001 From: david morales <118213696+davidmoralesz@users.noreply.github.com> Date: Fri, 9 Oct 2026 12:54:42 -0600 Subject: [PATCH] fix(workflows): give both lint workflows the same check name ci-pre-commit reported `lint / pre-commit` and ci-lint reports `lint / lefthook`, and checks-project requires the first. A repository moving to ci-lint therefore left its pull request waiting on a check that would never report. Both jobs are now named `hooks`, and both rulesets require `lint / hooks`. --- .github/workflows/ci-lint.yml | 5 ++++- .github/workflows/ci-pre-commit.yml | 5 ++++- rulesets/checks-dotgithub.json | 2 +- rulesets/checks-project.json | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-lint.yml b/.github/workflows/ci-lint.yml index c7a43ef..2aa84c1 100644 --- a/.github/workflows/ci-lint.yml +++ b/.github/workflows/ci-lint.yml @@ -49,7 +49,10 @@ permissions: {} jobs: lint: - name: lefthook + # Both lint workflows name this job `hooks`, so the check a ruleset requires is + # ` / hooks` whichever one a repository calls, and moving from + # ci-pre-commit to ci-lint does not strand a pull request waiting on the old name. + name: hooks runs-on: ubuntu-latest timeout-minutes: ${{ inputs.timeout-minutes }} permissions: diff --git a/.github/workflows/ci-pre-commit.yml b/.github/workflows/ci-pre-commit.yml index df4f761..92dba51 100644 --- a/.github/workflows/ci-pre-commit.yml +++ b/.github/workflows/ci-pre-commit.yml @@ -69,7 +69,10 @@ permissions: {} jobs: pre-commit: - name: pre-commit + # Both lint workflows name this job `hooks`, so the check a ruleset requires is + # ` / hooks` whichever one a repository calls, and moving from + # ci-pre-commit to ci-lint does not strand a pull request waiting on the old name. + name: hooks runs-on: ubuntu-latest timeout-minutes: ${{ inputs.timeout-minutes }} permissions: diff --git a/rulesets/checks-dotgithub.json b/rulesets/checks-dotgithub.json index 5ecd3f7..af7f4c6 100644 --- a/rulesets/checks-dotgithub.json +++ b/rulesets/checks-dotgithub.json @@ -35,7 +35,7 @@ "integration_id": 15368 }, { - "context": "lint / lefthook", + "context": "lint / hooks", "integration_id": 15368 }, { diff --git a/rulesets/checks-project.json b/rulesets/checks-project.json index 8b7a3a8..ae26100 100644 --- a/rulesets/checks-project.json +++ b/rulesets/checks-project.json @@ -27,7 +27,7 @@ "integration_id": 15368 }, { - "context": "lint / pre-commit", + "context": "lint / hooks", "integration_id": 15368 } ]