chore(deploy): remove v1 kubernetes-controller from chart, CI, scripts, docs#269
chore(deploy): remove v1 kubernetes-controller from chart, CI, scripts, docs#269JoshuaAFerguson wants to merge 1 commit into
Conversation
…s, docs The v1 controller was replaced by the K8s Agent in v2.0 but its dead config persisted across the deployment surface. Atomic removal of the remaining references now that the v2 architecture is the only path: Helm chart (chart/): - Delete templates/controller-deployment.yaml (whole file was guarded on `controller.enabled` which defaulted to false) - Remove controller PDB block from templates/pdb.yaml - Remove controller NetworkPolicy block from templates/networkpolicy.yaml - Remove controller ClusterRole + ClusterRoleBinding + SA from templates/rbac.yaml (the K8s Agent has its own RBAC bundle) - Remove controller ServiceMonitor from templates/servicemonitor.yaml - Remove streamspace.controller.labels / .serviceAccountName / .image helper defines from templates/_helpers.tpl - Trim NOTES.txt: remove the v1-controller upgrade-path stanza, point metrics port-forward at the api service instead of the dead controller service - Delete `controller:` values block (~75 lines) and the `networkPolicy.controller` sub-block from values.yaml CI workflows (.github/workflows/): - Drop kubernetes-controller from release.yml's release-notes image list and from its docker-scan matrix; add k8s-agent in its place - Replace kubernetes-controller in security-scan.yml's trivy matrix with the two real v2 agents (k8s-agent, docker-agent) Scripts: - scripts/local-deploy.sh: update the comment at the image-existence check from "K8s Agent REPLACES kubernetes-controller" to read in the past tense (the v1 controller was removed in v2) Docs: - docs/TROUBLESHOOTING.md: clarify the controller is fully removed, not just disabled-by-default Verified: - `helm lint chart/` exits clean - `helm template streamspace chart/` renders 806 lines (was 872 before; the 66-line shrinkage is the dead-config removal) Out of scope here (cleaned in fix/docker-compose-v2-agents branch): - scripts/local-build.sh KUBERNETES_CONTROLLER_IMAGE variable + grep filter + case branch — touched there to avoid cross-branch conflict
github-actions
Bot
added
the
documentation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8d80213b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| View metrics: | ||
| kubectl port-forward -n {{ .Release.Namespace }} \ | ||
| svc/{{ include "streamspace.fullname" . }}-controller 8080:8080 | ||
| svc/{{ include "streamspace.fullname" . }}-api 8080:8080 |
There was a problem hiding this comment.
This command now targets the API service but still hard-codes 8080:8080, while the chart’s default API service port is 8000 (api.service.port), so the post-install metrics check fails on a default install with a "service does not have a service port 8080" error. Update the port-forward mapping to use the API service port (or template it from values) so NOTES instructions work reliably.
Useful? React with 👍 / 👎.
|
This pull request has been automatically marked as stale because it has not had recent activity. Action Required:
|
github-actions
Bot
added
the
stale
|
This pull request was automatically closed due to inactivity. If you believe this was closed in error, please reopen it. |
1 participant
Summary
The v1 `streamspace-kubernetes-controller` was replaced by the K8s Agent in v2.0 — but its dead config was left behind across the deployment surface. Cleans up that residue atomically:
12 files changed, 22 insertions(+), 415 deletions(-) — almost all dead config / dead templates.
Verification
Test plan
Out of scope (already cleaned in companion branch)