Address object creation review feedback

Author: AussieScorcher

src/SimConnect.NET/AI/SimObjectManager.cs

@@ -487,8 +487,13 @@ private async Task<int> InvokeObjectCreationAsync(
                     {
                         registerPacketId(sendId, requestId);
                     }
+                    else
+                    {
+                        SimConnectLogger.Warning(
+                            $"SimObjectManager: Created object request {requestId}, but packet ID lookup failed: {SimConnectErrorMapper.Format(packetIdResult)}. Server errors cannot be correlated for this request.");
+                    }
 
-                    return packetIdResult;
+                    return (int)SimConnectError.None;
                 },
                 cancellationToken).ConfigureAwait(false);
         }

src/SimConnect.NET/SimConnectClient.cs

@@ -661,7 +661,7 @@ internal async Task<bool> GetIsMSFS2024Async(CancellationToken cancellationToken
                 throw new InvalidOperationException("Simulator identification is unavailable because SimConnect is not connected.");
             }
 
-            return await identification.Task.WaitAsync(TimeSpan.FromSeconds(5), cancellationToken).ConfigureAwait(false);
+            return await identification.Task.WaitAsync(cancellationToken).ConfigureAwait(false);
         }
 
         /// <summary>

tests/SimConnect.NET.UnitTests/SimObjectManagerTests.cs

@@ -103,4 +103,31 @@ public async Task SuccessRemovesNativePacketMapping()
         Assert.Equal(123u, created.ObjectId);
         Assert.False(manager.TryResolveRequestId(nativeSendId, out _));
     }
+
+    /// <summary>
+    /// Verifies creation can complete when native packet correlation is unavailable.
+    /// </summary>
+    [Fact]
+    public async Task SuccessWithoutPacketMappingStillCompletes()
+    {
+        uint clientRequestId = 0;
+        var nativeCallCompleted = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
+        using var client = new SimConnectClient("Unit test");
+        using var manager = new SimObjectManager(
+            client,
+            (title, livery, position, requestId, registerPacketId, cancellationToken) =>
+            {
+                clientRequestId = requestId;
+                nativeCallCompleted.SetResult();
+                return Task.FromResult((int)SimConnectError.None);
+            },
+            TimeSpan.FromSeconds(10));
+
+        var creation = manager.CreateObjectAsync("CoffeeCup", default);
+        await nativeCallCompleted.Task.WaitAsync(TimeSpan.FromSeconds(1));
+        manager.ProcessObjectCreated(clientRequestId, 123, string.Empty, default);
+
+        var created = await creation;
+        Assert.Equal(123u, created.ObjectId);
+    }
 }