From c3a0b9eb2d72f819000061fd3226327227cd6001 Mon Sep 17 00:00:00 2001 From: jan-kubica Date: Tue, 11 Aug 2026 06:52:43 +0200 Subject: [PATCH] fix: let release PR mutations finish --- .github/workflows/changeset-release-pr.test.mjs | 4 ++-- .github/workflows/changeset-release-pr.yml | 2 +- README.md | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/changeset-release-pr.test.mjs b/.github/workflows/changeset-release-pr.test.mjs index f044830..47bb152 100644 --- a/.github/workflows/changeset-release-pr.test.mjs +++ b/.github/workflows/changeset-release-pr.test.mjs @@ -13,10 +13,10 @@ const indexOf = (text) => { return index; }; -test("version PR mutations use latest-run branch concurrency", () => { +test("version PR mutations finish under branch concurrency", () => { assert.match( workflow, - /concurrency:\n {6}group: changeset-release-pr-\$\{\{ github\.ref \}\}\n {6}cancel-in-progress: true/, + /concurrency:\n {6}group: changeset-release-pr-\$\{\{ github\.ref \}\}\n {6}cancel-in-progress: false/, ); }); diff --git a/.github/workflows/changeset-release-pr.yml b/.github/workflows/changeset-release-pr.yml index 77a89d5..4eff80b 100644 --- a/.github/workflows/changeset-release-pr.yml +++ b/.github/workflows/changeset-release-pr.yml @@ -60,7 +60,7 @@ jobs: timeout-minutes: 15 concurrency: group: changeset-release-pr-${{ github.ref }} - cancel-in-progress: true + cancel-in-progress: false steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: diff --git a/README.md b/README.md index 97d83f1..86a290a 100644 --- a/README.md +++ b/README.md @@ -252,12 +252,12 @@ jobs: ``` The caller must provide `changeset`, `changeset:version`, and a `.changeset/config.json`. -The shared workflow serializes each target branch with latest-run concurrency and -skips write-capable steps when its trigger commit is no longer the branch head. A -current no-op run closes any stale version PR and deletes its generated branch, so -interrupted runs converge without a duplicate release PR. Callers may use matching -workflow-level concurrency to cancel obsolete setup work before the reusable job -starts. +The shared workflow serializes each target branch without interrupting an active +release mutation, and skips write-capable steps when its trigger commit is no longer +the branch head. A current no-op run closes any stale version PR and deletes its +generated branch, so queued runs converge without a duplicate release PR. Callers +should use matching workflow-level concurrency without cancellation; newer pushes +replace obsolete pending runs while the active mutation finishes. For hybrid repositories, `changeset:version` must synchronize the selected package version into every npm, Cargo manifest, Python, and central `VERSION` surface. With