Persist relation#103
Open
wolfgang-302 wants to merge 4 commits into
Open
Conversation
…hips Committer: Wolfgang Meiners <wolfgang@Wolfgangs-MBP.fritz.box> On branch persist_relation Changes to be committed: modified: colanderalchemy/schema.py modified: tests/models.py new file: tests/test_persist_data.py redefine name
changed inspect(context) to inspect(context, raiseerr=False) inserted test_persist_data.py to tests/__init__.py
Collaborator
|
hmm.. it seems that the tests are failing because SQLAlchemy now requires at least py2.7 . I'll have to take a look when I can find some time. |
|
I did face this bug and tested this PR ; it actually fix the bug. The two failing runs in Travis are not related to this PR but to setuptools lifecycle (current master would fail the same way). @tisdall Any plan to merge this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLAlchemySchemaNode.objectify() can not persist related data. See comments on issue 101.
This PR redefines this method. Related data can be persisted, all tests pass.
Wolfgang