Skip to content

Update TenantRequestMetricsTagProvider to use the UserAgent on RequestContext #2541

Description

@amorton

Code in TenantRequestMetricsTagProvider manually extracts the User Agent from the header and processes.

We also now have a well designed UserAgent class that is always non-null on the RequestContext.

This task is to update TenantRequestMetricsTagProvider to so it adds the same information to the tags it does not, but uses the UserAgent class which is where we centralize the processing. I think UserAgent.product is the same thing as the code currently extracts.

If there is no RequestContext then we should fall back to the full user agent string (not just the a part of it) and if no header use the UNKOWN_VALUE as it does now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions