README Issues

[maxGreenblatt]

Hi @srob650 -

I work at Plex and I wanted to reach out to help you with the issues you mentioned in your README.

Issue 1: My first thought would be to fallback to the language of the library (passed in as lang, rather than English). Would that suit you any better? We do require that a show have a language, so that's why Unknown doesn't work. If you don't like lang as a fallback, maybe you can let me know what kinds of shows from TVMaze do not return a language so I can have a better sense of the use case.

Issue 2: Date based shows can be very tricky. Can I see some logs and/or examples of what happens with date-based shows, so that I can be more helpful?

[srob650]

Max,

Thanks so much for your reply! It's been a while since I even thought about this code :)

Issue 1: Falling back to lang seems fine to me. I didn't really understand that that was the library language when writing this so that makes sense to me now.

Issue 2: I've tried to reproduce my issues with date-based shows and it actually seems like they are no longer happening. My code hasn't changed, nor has the input of types of shows I had issues with, so something must have changed on the PMS side to help this out :)

I'm so glad you posted here because I let this fall by the wayside for a while, but now with the simple lang change I think this is probably ready to be out of beta. If you feel so motivated I'd gladly take any suggestions to make my code better as I'm just a hobbyist. Otherwise thank you so much for reaching out!

[srob650]

Ah shoot, I take it back. The date-based issue is still there. Let me gather some data on this

[srob650]

Ok, here is the log from a server with two episodes in it. File structure is as follows:

Conan
 - Season 2015
     - Conan - (2015-12-17).mkv
 - Season 2016
     - Conan - (2016-01-04).mkv

Notice on line 112 Update() has been called and my code properly identifies Season 2015 and Season 2016.

Now scroll to line 132 and Update() has for some reason been called again and all of a sudden it's identifying a season 0 and season 2016.

Is there something with the way that I've written my code that is causing Update() to be called in a weird way? What else could be causing this?

[srob650]

@maxGreenblatt,

Are you or anyone else from the Plex team able to help me with this issue so I can get this agent officially completed?

[srob650]

I'm wondering if it is somehow related to having season folders which are years instead of 2-digit numbers? For example:
The Tonight Show Starring Jimmy Fallon / Season 2016 /

[srob650]

Here is an excerpt from the Plex Media Scanner.log when I add the following show:
TV/Conan/Season 2016/Conan - 2016-10-06.mkv

Oct 09, 2016 12:27:49.127 [0x10844e3c0] DEBUG - Adding subdirectory for scanner: /Users/srob/TV/Conan
Oct 09, 2016 12:27:49.141 [0x10844e3c0] DEBUG -     * Scanning directory /Users/srob/TV/Conan (parent: yes)
Oct 09, 2016 12:27:49.142 [0x10844e3c0] DEBUG - Adding file for scanner: /Users/srob/TV/Conan/.DS_Store
Oct 09, 2016 12:27:49.142 [0x10844e3c0] DEBUG - Adding subdirectory for scanner: /Users/srob/TV/Conan/Season 2016
Oct 09, 2016 12:27:49.143 [0x10844e3c0] DEBUG - Skipping over directory 'Conan', as nothing has changed; removing 0 media items from map.
Oct 09, 2016 12:27:49.143 [0x10844e3c0] DEBUG -     * Scanning directory /Users/srob/TV/Conan/Season 2016 (parent: yes)
Oct 09, 2016 12:27:49.144 [0x10844e3c0] DEBUG - Adding file for scanner: /Users/srob/TV/Conan/Season 2016/.DS_Store
Oct 09, 2016 12:27:49.144 [0x10844e3c0] DEBUG - Adding file for scanner: /Users/srob/TV/Conan/Season 2016/Conan - 2016-10-06.mkv
Oct 09, 2016 12:27:49.144 [0x7000089e1000] DEBUG - HTTP requesting GET http://127.0.0.1:32400/:/metadata/updateProgressMessage?message=Scanning%20Conan
Oct 09, 2016 12:27:49.145 [0x10844e3c0] DEBUG - Skipping over directory 'Conan/Season 2016', as nothing has changed; removing 0 media items from map.
Oct 09, 2016 12:27:49.146 [0x7000089e1000] DEBUG - HTTP 200 response from GET http://127.0.0.1:32400/:/metadata/updateProgressMessage?message=Scanning%20Conan
Oct 09, 2016 12:27:49.147 [0x7000089e1000] DEBUG - HTTP requesting GET http://127.0.0.1:32400/:/metadata/updateProgressMessage?message=Scanning%20Conan%2FSeason%202016
Oct 09, 2016 12:27:49.150 [0x7000089e1000] DEBUG - HTTP 200 response from GET http://127.0.0.1:32400/:/metadata/updateProgressMessage?message=Scanning%20Conan%2FSeason%202016

The scanner clearly finds it but my metadata agent is never called (Search or Update). I have no clue what other logs to look through to figure out why it just doesn't try anything for this episode.

[ZeroQI]

Scanner decide the season and ep number. If the year is used as season the ep number will not have relation to the date so the agent need to pull the filename for each episode, and match to the episode date info.
If the agent isn't called it is not set for the library or crashed and plex needs restarting.

PS: Btw do not put the date between parenthesis that won't work well.
I could add date format to my scanner but need filenames to reproduce